feat: remove last buy price slack updates unless notifyDebug or notifyOrder are enabled #518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Confirm are enabled
|
Sounds cool - how can I set notifyOrderConfirm notifyDebug to false? |
|
@rando128 Are you able to write tests for the changes? |
Closed
chrisleekr
changed the title
|
Thx @chrisleekr. Sorry for not writing tests for this, but it was beyond my skills. Now that I saw what you did for this merge, I hope to be able to add tests for my next PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The existing slack notification settings are still quite verbose even when notifyOrderConfirm and notifyDebug are disabled. Also as a user, if I only enable notifyOrderExecute, I expect to not receive trailing price update notifications.
Related Issue
This PR tries to address #515
How Has This Been Tested?
This has been tested in live mode on my own setup and trailing updates are not sent anymore with notifyOrderConfirm and notifyDebug set to false.