-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: non-active exchange symbols #478
fix: non-active exchange symbols #478
Conversation
It can cause confusion during the time when Binance is in maintenance. Exchange info returns the symbol status as the below link And some good summary of it. It's a bit hairy because BREAK can be just in some downtime. I had some thought about it. For example, if it's TRADING, then show this loading indicator. If not TRADING, show an exclamation mark with some notes. |
Hello @chrisleekr However, I think twice to make things easier :) Besides your suggestion, what do you think about the following?
I think this will be easier to catch. |
@habibalkhabbaz that is much better idea! |
Done @chrisleekr |
@habibalkhabbaz It will be also useful to add new symbol to main screen immediatelly to be visible. Currently it is waiting for the first price change which will make this indication useless. If I add multiple inactive symbols then I even see the number of pages is incremented but selecting the last page I'll get empty screen without any indication what's wrong. |
You are right @uhliksk |
Done @uhliksk @chrisleekr |
Great job @habibalkhabbaz! |
@habibalkhabbaz @uhliksk Is this ready to review/merge? |
Hello @chrisleekr |
<Popover.Content> | ||
{symbol} exists in your monitoring list. However, it is not | ||
active on Binance due to emergency downtime, due to it was | ||
actually delisted or due to market move too fast. For more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
VERY GOOD!! 💯
I love it. Merging now. |
Description
Based on #476 we found that the Binance API is returning all their symbols even the non-active ones.
Hence, this PR is going to squash those non-active symbols from our exchange symbols list.
Related Issue
#476
Motivation and Context
How Has This Been Tested?
Write tests to check if the symbols were filtered correctly or not.
Screenshots (if appropriate):