-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: refactor tradingview #383
Conversation
Codecov Report
@@ Coverage Diff @@
## master #383 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 80 80
Lines 2936 2936
Branches 546 546
=========================================
Hits 2936 2936
Continue to review full report at Codecov.
|
That is good. Try to run a few days to see how it goes. |
My results should be taken with a grain of salt, since I'm still running Ubuntu 18.04 and docker version 3.7 is not yet supported (I put 3.3 on the docker.yml )and even npm is warning about:
But I'll let it run for a few days and see how it performs. |
@Rayn0r I am running Ubuntu 18.04 as well
And I don't have an issue running docker compose 3.7 My docker-compose version is
|
Description
The TradingView container was developed with a very simple python web server.
However, it was found that TradingView container was causing some issues with some scenarios.
To resolve the issue, this PR has refactored TradingView container with Flask.
How to test:
Related Issue
#368 #381
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):