Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update last buy removal threshold min/step #379

Merged
merged 1 commit into from
Oct 30, 2021

Conversation

chrisleekr
Copy link
Owner

Description

@Rayn0r has reported XRPBTC/SHIBBUSD are removing the coin due to the last buy removal threshold cannot be set under the minimum notional.

This PR is rectifying the issue.

Related Issue

#372

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

image

@chrisleekr chrisleekr linked an issue Oct 30, 2021 that may be closed by this pull request
@codecov-commenter
Copy link

Codecov Report

Merging #379 (5feaf2f) into master (d0ed1af) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #379   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           80        80           
  Lines         2936      2936           
  Branches       546       546           
=========================================
  Hits          2936      2936           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0ed1af...5feaf2f. Read the comment docs.

@chrisleekr chrisleekr merged commit 155b1d5 into master Oct 30, 2021
@chrisleekr chrisleekr deleted the fix/last-buy-removal-threshold branch November 9, 2021 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Last buy price gets removed
2 participants