Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enhanced tradingview #375

Merged
merged 2 commits into from
Oct 30, 2021
Merged

feat: enhanced tradingview #375

merged 2 commits into from
Oct 30, 2021

Conversation

chrisleekr
Copy link
Owner

Description

In this PR, the way to retrieve TradingView technical analysis has been enhanced.

Previously, it was retrieving a single symbol TradingView technical analysis per tick.
Now it will retrieve all symbol's TradingView technical analysis per tick.

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

@codecov-commenter
Copy link

codecov-commenter commented Oct 26, 2021

Codecov Report

Merging #375 (3646740) into master (d445b2e) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #375   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           80        80           
  Lines         2879      2936   +57     
  Branches       513       546   +33     
=========================================
+ Hits          2879      2936   +57     
Impacted Files Coverage Δ
app/cronjob/trailingTrade/step/place-buy-order.js 100.00% <ø> (ø)
app/cronjob/trailingTrade/step/determine-action.js 100.00% <100.00%> (ø)
...ob/trailingTradeIndicator/step/get-trading-view.js 100.00% <100.00%> (ø)
app/helpers/cache.js 100.00% <0.00%> (ø)
app/server-binance.js 100.00% <0.00%> (ø)
app/helpers/binance.js 100.00% <0.00%> (ø)
app/server-frontend.js 100.00% <0.00%> (ø)
app/cronjob/trailingTrade.js 100.00% <0.00%> (ø)
app/cronjob/trailingTradeIndicator.js 100.00% <0.00%> (ø)
app/frontend/local-tunnel/configure.js 100.00% <0.00%> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 366761b...3646740. Read the comment docs.

@peterolayinka
Copy link

This comment is irrelevant to the PR, but great work here. @chrisleekr

@chopeta
Copy link

chopeta commented Oct 26, 2021

Nice! Testing it here. Will let you know if something comes up.
So far, so good, all symbols are getting TV data at the same time.

@chopeta
Copy link

chopeta commented Oct 26, 2021

I don't think this is a PR bug because I had it actually on master as well... maybe is just my machine...

But I am getting insane amounts of Slack msgs. like this:

XRPDOWNUSDT Buy Action Grid Trade #1 (20:54:18.481): TradingView Recommendation STRONG_SELL
- Current API Usage: 72

This is for this symbol:

image

And here's my config. (Buy is currently disabled globally):

image

Any idea?

@chrisleekr
Copy link
Owner Author

Thanks @peterolayinka

@chopeta
I simply removed that notification since it's just debugging message.

@chrisleekr chrisleekr merged commit d0ed1af into master Oct 30, 2021
@chrisleekr chrisleekr mentioned this pull request Oct 30, 2021
@chrisleekr chrisleekr deleted the feat/enhance-tradingview branch November 9, 2021 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants