-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Filter symbols in the frontend #242
Conversation
public/js/SearchIcon.js
Outdated
} | ||
|
||
render() { | ||
document.addEventListener("touchstart", function () { }, true); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does this line do?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I used that code from the search box that I found. I didn't try without it though. I think it sets the event listener to the search box? But from what I know it should work without it. Let me test :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I don't think that line is necessary, but yeah, test it out. :)
Nice work @pedrohusky I think you still have some formatting issues, but I can get it to fix. Let me take a look when I get time. |
Hmm, your code was ok and I tried to make it better, but I found some browser compatibility issues. I may focus on another feature and get back to this. |
Hi. What issues? Just to know. I could see why the incompatibility. |
@pedrohusky I close this PR because I made another PR #253 with the latest code. |
Description
A simple search box to filter the symbols. It is animated and such.
Related Issue
Filter symbols in the frontend - [#120]
Motivation and Context
Sometimes is hard to find the symbol with many monitored. This will help us.
How Has This Been Tested?
Searching something, then the data was filtered.
Screenshots: