Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Filter symbols in the frontend #242

Closed
wants to merge 3 commits into from

Conversation

pedrohusky
Copy link
Contributor

Description

A simple search box to filter the symbols. It is animated and such.

Related Issue

Filter symbols in the frontend - [#120]

Motivation and Context

Sometimes is hard to find the symbol with many monitored. This will help us.

How Has This Been Tested?

Searching something, then the data was filtered.

Screenshots:

Captura de Tela (153)
Captura de Tela (154)

@chrisleekr chrisleekr changed the title Search Symbol. To filter symbols in frontend. feat: Filter symbols in the frontend Jul 7, 2021
@chrisleekr chrisleekr linked an issue Jul 7, 2021 that may be closed by this pull request
}

render() {
document.addEventListener("touchstart", function () { }, true);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this line do?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I used that code from the search box that I found. I didn't try without it though. I think it sets the event listener to the search box? But from what I know it should work without it. Let me test :)

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I don't think that line is necessary, but yeah, test it out. :)

@chrisleekr
Copy link
Owner

Nice work @pedrohusky

I think you still have some formatting issues, but I can get it to fix.

Let me take a look when I get time.

@chrisleekr
Copy link
Owner

Hmm, your code was ok and I tried to make it better, but I found some browser compatibility issues.

I may focus on another feature and get back to this.

@pedrohusky
Copy link
Contributor Author

pedrohusky commented Jul 9, 2021

Hmm, your code was ok and I tried to make it better, but I found some browser compatibility issues.

I may focus on another feature and get back to this.

Hi. What issues? Just to know. I could see why the incompatibility.

@chrisleekr
Copy link
Owner

@pedrohusky I close this PR because I made another PR #253 with the latest code.
Thanks again for your contributions!

@chrisleekr chrisleekr closed this Jul 30, 2021
@pedrohusky pedrohusky deleted the filter-symbols branch August 11, 2021 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Filter symbols in the Frontend
2 participants