Skip to content

fix url assembly in forceUpdate #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
chrisjoyce911 merged 1 commit into from
Jun 10, 2025
Merged

fix url assembly in forceUpdate #160

chrisjoyce911 merged 1 commit into from
Jun 10, 2025

Conversation

@womoak75
Copy link
Contributor

@womoak75 womoak75 commented Nov 1, 2024

in method

bool esp32FOTA::forceUpdate(const char* firmwareHost, uint16_t firmwarePort, const char*  firmwarePath, bool validate )

url assembly was missing a '://' between protocol and host part.

forceUpdate("update.myhost.com", 80, "/firmware.bin", true)

resulted in

"httpupdate.myhost.com:80/firmware.bin"

instead of

"http://update.myhost.com:80/firmware.bin"

@chrisjoyce911 chrisjoyce911 merged commit 24e6072 into chrisjoyce911:master Jun 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chrisjoyce911 chrisjoyce911 chrisjoyce911 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@womoak75 @chrisjoyce911