Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FR: Support comments disabling multiple rules #2

Closed
1 task done
Popkornium18 opened this issue Sep 27, 2023 · 3 comments
Closed
1 task done

FR: Support comments disabling multiple rules #2

Popkornium18 opened this issue Sep 27, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@Popkornium18
Copy link
Contributor

Bug Description

Currently it is not possible to ignore multiple pyright rules, as nvim-rulebook does not support the # pyright: ignore[ruleA,ruleB,ruleC] syntax and just chains them like this# pyright: ignore [ruleA] # pyright: ignore [ruleB] # pyright: ignore [ruleC]

Relevant Screenshot

No response

To Reproduce

  • Introduce statement with multiple errors like unused = undefined(False)
  • Try to ignore all the errors
  • nvim-rulebook keeps chaining ignore comments indefinitely

neovim version

0.9

Make sure you have done the following

  • I have updated to the latest version of the plugin.
@Popkornium18 Popkornium18 added the bug Something isn't working label Sep 27, 2023
@chrisgrieser chrisgrieser added enhancement New feature or request and removed bug Something isn't working labels Sep 27, 2023
@chrisgrieser
Copy link
Owner

yeah, that's currently not implemented yet.

@chrisgrieser chrisgrieser changed the title [Bug]: It is not possible to ignore multiple pyright rules FR: Support comments disabling multiple rules Sep 27, 2023
@github-actions GitHub Actions
Copy link

This issue has been automatically marked as stale.
If this issue is still affecting you, please leave any comment, for example "bump", and it will be kept open.

@github-actions github-actions bot added the Stale label Mar 26, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 2, 2024

This issue has been closed due to inactivity, and will not be monitored.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Apr 2, 2024
chrisgrieser added a commit that referenced this issue Nov 17, 2024
@chrisgrieser
feat(ignoreRule): support comments disabling multiple rules (#2)
8beb196
chrisgrieser added a commit that referenced this issue Nov 17, 2024
@chrisgrieser
feat(ignoreRule): support comments disabling multiple rules (#2)
ade184b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Popkornium18 @chrisgrieser