fix for workaround to issue sml_server does not decode data from device DZMeteringGmbH_WS_7412.1 (negative values) #125 #1

chrischris616 · 2023-08-11T07:45:00Z

there was on sml message more included into the workaround. it is the power of L1, the existing power sum will be renamed.

static const unsigned char dzg_power_name_sum[] = {1, 0, 16, 7, 0, 255};
static const unsigned char dzg_power_name_L1[] = {1, 0, 36, 7, 0, 255};

Identifiers beginning with an underscore followed by a capital letter are reserved. ISO C99/11 7.1.3p1 and p2.

…hout effect

…epresentation may be non-zero

…of better knowledge

TheCount's "Cleanup and bugfixes", merge-able

[andig] Provide better error message

fix compile warnings

[test] upgrade unity

After discussions in issue #105 I asked DZG, and they confirmed the bug was fixed in firmware version 1.2 and 1.3, which ship with serial numbers starting with "1 DZG 00 6.." (in decimal). Compare the serial number, and only apply the workaround if it is indeed less than static const unsigned char dzg_serial_fixed[] = {0x0a, 0x01, 'D', 'Z', 'G', 0x00, 0x03, 0x93, 0x87, 0x00}; which is "1 DZG 00 60000000" in their decimal representation. This fixes #105. Co-authored-by: Johannes Berg <[email protected]>

…pository squash merged the Andreas Moog changes excluding .gitlab-ci.yml

The data types are described on pages 44 and 45 in the technical guideline: https://www.bsi.bund.de/SharedDocs/Downloads/DE/BSI/Publikationen/TechnischeRichtlinien/TR03109/TR-03109-1_Anlage_Feinspezifikation_Drahtgebundene_LMN-Schnittstelle_Teilb.pdf?__blob=publicationFile

Debuild squash

Cloudsmith

fix compiler warning when building without libuuid, uuid_t is `unsigned char`, so the dummy we replace it with should match that.

see issue #113

this is a fix of the DZMeter workaround for wrong values.

juriglx and others added 30 commits January 18, 2013 08:41

simpler sml_transport_read method

9e6f675

size_t is unsigned

1f18d1e

added newline to error msg

910a312

Fixed endianness bug in sml_number_init

90e3e75

Fixed endianness bug in sml_number_init - revised

133ee5e

Ignore dpkg-buildpackage stuff

57992d7

Properly resolve library dependencies

fef8683

Removed undefined behaviour due to reserved identifier names

766367f

Identifiers beginning with an underscore followed by a capital letter are reserved. ISO C99/11 7.1.3p1 and p2.

Fixed free() of uninitialised pointer

bf2cc16

Ignore editor files

ba05ec8

Typo

e53f8b1

Freeing macros matching initialisation macros

c4d2a1f

Fixed bad aliasing, unchecked malloc() return value and statement wit…

5a60196

…hout effect

Null pointers must be initialised explicitly because their internal r…

70d1038

…epresentation may be non-zero

Clean up properly in test cases

5e222d9

Fixed signed comparison bug

7cdfdc7

Use puts for non-formatted output.

f28fde1

Choosing correct iteration type

c4f2702

Use size_t for cursor position (possible ABI breaking change)

54898ce

Use safe conversions instead of dangerous function pointer casts

cb05145

Updating Unity

76b17ad

Defining inline functions with static linkage

152dbf1

Enable more warnings regarding standards complicance

f5b3c9d

Provide better error message

9b2533b

fix merge conflicts: prefer TheCount's version over HEAD due to lack …

bd33967

…of better knowledge

Merge pull request dailab#5 from r00t-/thecount-fixes

aa7519d

TheCount's "Cleanup and bugfixes", merge-able

Merge pull request dailab#2 from andig/master

6f3030f

[andig] Provide better error message

fix warnings

294f5fc

Merge pull request dailab#11 from r00t-/fix_warnings

a9a3beb

fix compile warnings

print messages to stderr, not stdout, with 'libsml:'-tag

70e579e

r00t- and others added 27 commits March 29, 2021 12:24

Merge pull request #99 from r00t-/upgrade_unity_to_v2.5.2

d656822

[test] upgrade unity

(squashed) changes from debian packaging repository

2b71103

changed to native to make it build again

bf61039

Merge pull request #111 from narc-Ontakac2/squash_debian_packaging_re…

7cc80c5

…pository squash merged the Andreas Moog changes excluding .gitlab-ci.yml

[transport] generate log message on crc error

64c5e2c

added debuild+pbuilder as a release workflow

d0e5b20

- set build tag

e8b2f5e

Merge pull request #116 from narc-Ontakac2/debuild-squash

c494928

Debuild squash

added cloudsmith upload

b591615

removed setting of version tagwq by debuild

a4f6efa

added Github release howto

abc8423

documented cloudsmith repo usage

db50048

Merge pull request #119 from narc-Ontakac2/cloudsmith

7e7c5d4

Cloudsmith

Removes compiler warning about char -> unsigned char (#118)

22efde4

fix compiler warning when building without libuuid, uuid_t is `unsigned char`, so the dummy we replace it with should match that.

added nmu to changelog

a19a522

minor changes that came up when preparing debian branch

695f765

added trixie

262ac43

RC 1.0.2

75a5cf8

Added official debian package

44c7401

Improxed explanation

f2fc936

Minor improvement

5420f5c

rename hexdump() to sml_hexdump()

ad22f94

see issue #113

debian/control: build does not require root

b9aec62

release 1.1.0

85bb28a

Update sml_list.c

f43e8ac

this is a fix of the DZMeter workaround for wrong values.

chrischris616 added the bug Something isn't working label Aug 11, 2023

chrischris616 self-assigned this Aug 11, 2023

chrischris616 mentioned this pull request Aug 11, 2023

sml_server does not decode data from device DZMeteringGmbH_WS_7412.1 (negative values) volkszaehler/libsml#125

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix for workaround to issue sml_server does not decode data from device DZMeteringGmbH_WS_7412.1 (negative values) #125 #1

fix for workaround to issue sml_server does not decode data from device DZMeteringGmbH_WS_7412.1 (negative values) #125 #1

chrischris616 commented Aug 11, 2023

fix for workaround to issue sml_server does not decode data from device DZMeteringGmbH_WS_7412.1 (negative values) #125 #1

Are you sure you want to change the base?

fix for workaround to issue sml_server does not decode data from device DZMeteringGmbH_WS_7412.1 (negative values) #125 #1

Conversation

chrischris616 commented Aug 11, 2023