fix(ci): backport canonical bypass-audit v1.21.2 hardening by chris-yyau · Pull Request #52 · chris-yyau/helmet

chris-yyau · 2026-06-05T13:07:42Z

Backports the canonical bypass-audit hardening (pipeline v1.21.1) to helmet's own main, which was at v1.21.0 after #51. Keeps helmet — the drift-check CANON source (scripts/check-pipeline-drift.sh reads helmet's own stamp) — in sync with the standard now propagated across the fleet (busdriver #181, perch #52, chrisyau.me #137, jikdak #172, growth-engine #72).

What changes (v1.21.0 → v1.21.1)

Audit every pushed commit (not just HEAD) — files one summary issue for all bypassing commits (no content-creation rate limit; no false-positive on a large legit merge).
Count only PRs merged into main (merged_at != null && base.ref == main) — a commit merely contained in an open/non-main PR can't mask a direct push.
contents: read for /commits/{sha}/pulls on private repos; separated stderr (no false red-X); exact-label existence check; pipefail-safe pipes; commit subjects sanitized + inline-code-wrapped (no Markdown injection); audit-trail comments made org/user-accurate.

Validation

litmus PASS + security review CLEAN on the byte-identical canonical (reference PR chris-yyau/busdriver#181).

Follow-up: the SKILL.md embedded bypass-audit template excerpt still shows the v1.21.0 design and should be refreshed so onboarding generates v1.21.1.

🤖 Generated with Claude Code

Summary by cubic

Backports the canonical bypass-audit v1.21.2 to harden detection of direct pushes and prevent silent gaps. Keeps helmet (drift-check CANON) aligned with the fleet standard.

New Features
- Audit every commit in a push, not just HEAD.
- File one Markdown-safe summary issue listing all bypassing commits.
Bug Fixes
- Only mark as non-bypass if merged via a PR to main.
- Read push commits from $GITHUB_EVENT_PATH with jq; fail-closed if payload is unreadable or .commits is not an array (no silent HEAD-only fallback).
- Fail the run on indeterminate API or issue-create errors; continue auditing the rest.
- Add contents: read; separate gh api stderr; make pipes pipefail-safe; increase timeout to 10 minutes.
- Exact admin-bypass label check with fallback create.
- Sanitize commit subjects (strip unsafe chars) and wrap in inline code to prevent Markdown injection.
- Cap audits to 256 commits per push; fail the run if exceeded to avoid gaps.

^{Written for commit da00a92. Summary will update on new commits.}

coderabbitai · 2026-06-05T13:07:51Z

Warning

Review limit reached

@chris-yyau, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 37 minutes and 59 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 8a963352-8a35-4b2d-906d-f268eb577d8b

📥 Commits

Reviewing files that changed from the base of the PR and between b502a04 and da00a92.

📒 Files selected for processing (1)

.github/workflows/bypass-audit.yml

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 497771f134

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-06-05T13:10:13Z

-          COMMIT_MSG: ${{ github.event.head_commit.message }}
          RUN_ID: ${{ github.run_id }}
+          HEAD_SHA: ${{ github.sha }}
+          COMMITS_JSON: ${{ toJSON(github.event.commits) }}


Avoid passing the whole push payload through env

For pushes with many commits or unusually large commit messages, toJSON(github.event.commits) can exceed the per-environment-string limit on Ubuntu runners before this bash step even starts, so none of the new loop, MAX_AUDIT failure, or issue creation logic runs. This is especially likely because the workflow now tries to handle up to 256 commits and each commit object includes message, author, URLs, and file lists; read the commits from $GITHUB_EVENT_PATH inside the script instead of materializing the entire array as one env var.

Useful? React with 👍 / 👎.

cubic-dev-ai

1 issue found across 1 file

_{Reply with feedback, questions, or to request a fix.

Re-trigger cubic}

Bring helmet's bypass-audit.yml from v1.21.0 to the canonical v1.21.1 the fleet now runs: audit every pushed commit, count only PRs merged into main, fail-on-indeterminate, exact-label check, separated stderr, contents:read for private repos, one Markdown-safe summary issue, pipefail-safe pipes. Keeps helmet (the drift-check CANON source) in sync with the propagated standard. Generated with [Claude Code](https://claude.ai/code) via [Happy](https://happy.engineering) Co-Authored-By: Claude <noreply@anthropic.com> Co-Authored-By: Happy <yesreply@happy.engineering>

toJSON(github.event.commits) materialized the whole push payload (up to 2048 commits, each with message + file lists + URLs) into a single env var. With a large push that can exceed the runner's env/ARG_MAX limit (~2 MB), making the audit step fail to exec before any logic runs — silently suppressing the very bypass this workflow exists to detect. Read commit ids and messages from $GITHUB_EVENT_PATH with jq instead (file data, never shell-interpolated), and fail the run when the payload is unreadable, not JSON, or .commits is not an array (indeterminate), so a multi-commit bypass cannot slip through a silent HEAD-only fallback. A valid but empty commit list still legitimately falls back to HEAD. Bumps the helmet-pipeline stamp v1.21.1 -> v1.21.2. Flagged independently by codex and cubic on the converged fleet PRs. Generated with [Claude Code](https://claude.ai/code) via [Happy](https://happy.engineering) Co-Authored-By: Claude <noreply@anthropic.com> Co-Authored-By: Happy <yesreply@happy.engineering>

## [1.22.1](v1.22.0...v1.22.1) (2026-06-05) ### Bug Fixes * **ci:** backport canonical bypass-audit v1.21.2 hardening ([#52](#52)) ([43b73aa](43b73aa))

This comment was marked as outdated.

Sign in to view

chatgpt-codex-connector Bot reviewed Jun 5, 2026

View reviewed changes

cubic-dev-ai Bot reviewed Jun 5, 2026

View reviewed changes

Comment thread .github/workflows/bypass-audit.yml Outdated

chris-yyau force-pushed the ci/backport-bypass-audit-v1.21.1 branch from 497771f to 7d22ddd Compare June 5, 2026 13:19

This comment was marked as outdated.

Sign in to view

chris-yyau changed the title ~~fix(ci): backport canonical bypass-audit v1.21.1 hardening~~ fix(ci): backport canonical bypass-audit v1.21.2 hardening Jun 5, 2026

codescene-delta-analysis Bot approved these changes Jun 5, 2026

View reviewed changes

chris-yyau merged commit 43b73aa into main Jun 5, 2026
17 checks passed

chris-yyau deleted the ci/backport-bypass-audit-v1.21.1 branch June 5, 2026 14:32

chris-yyau pushed a commit that referenced this pull request Jun 5, 2026

chore(release): 1.22.1 [skip ci]

bcc7e37

## [1.22.1](v1.22.0...v1.22.1) (2026-06-05) ### Bug Fixes * **ci:** backport canonical bypass-audit v1.21.2 hardening ([#52](#52)) ([43b73aa](43b73aa))

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(ci): backport canonical bypass-audit v1.21.2 hardening#52

fix(ci): backport canonical bypass-audit v1.21.2 hardening#52
chris-yyau merged 2 commits into
mainfrom
ci/backport-bypass-audit-v1.21.1

chris-yyau commented Jun 5, 2026 •

edited by cubic-dev-ai Bot

Loading

Uh oh!

coderabbitai Bot commented Jun 5, 2026 •

edited

Loading

Review limit reached

Uh oh!

This comment was marked as outdated.

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

chatgpt-codex-connector Bot Jun 5, 2026

Uh oh!

cubic-dev-ai Bot left a comment •

edited

Loading

Uh oh!

Uh oh!

This comment was marked as outdated.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

chris-yyau commented Jun 5, 2026 • edited by cubic-dev-ai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What changes (v1.21.0 → v1.21.1)

Validation

Summary by cubic

Uh oh!

coderabbitai Bot commented Jun 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review limit reached

Uh oh!

This comment was marked as outdated.

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Jun 5, 2026

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

This comment was marked as outdated.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

chris-yyau commented Jun 5, 2026 •

edited by cubic-dev-ai Bot

Loading

coderabbitai Bot commented Jun 5, 2026 •

edited

Loading

cubic-dev-ai Bot left a comment •

edited

Loading