Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs discussion and possibly further tests. Designed to build components. Any copy features built based on
bel
will likely want to copyel.events
from element to element rather than their current implementation so this is likely a breaking change.There's an alternate implementation that looks like this:
In this case, the listener points to the
el
anddispatch
looks for theevents
object property. This may be a better pattern since it's easier for the implementer to overwritehandleEvent
at the element level. When copying events, you can iterate overObject.keys(events)
.It may be worse because when copying events between elements, you need to copy the events expando property and also add
handleEvent
instead of it all coming in the same package. You just have to remember skiphandleEvent
when iterating theevents
object.