Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes choojs/nanohtml#51. 'false' no longer renders #79

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

mjstahl
Copy link

@mjstahl mjstahl commented Jun 21, 2019

This is a breaking change.

Alright, following the calls of concat I found where to make the change (I believe). Thank you @goto-bus-stop

I did find an error in the process and added a test and fix for it (reference https://github.com/choojs/hyperx/pull/79/files#diff-9b0f7b44960ccf14de3ba5c706daf2b4R30). Results in:

/Users/mark/Projects/JavaScript/hyperx/node_modules/virtual-dom/virtual-hyperscript/index.js:77
        throw UnexpectedVirtualElement({
        ^

Error: Unexpected virtual child passed to h().

This is because of what virtual-dom supports (https://github.com/Matt-Esch/virtual-dom/blob/master/virtual-hyperscript/index.js#L74).

@mjstahl mjstahl changed the title Fixes choojs/nanohtml#51. 'false' doesn't render Fixes choojs/nanohtml#51. 'false' no longer renders Jun 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant