favicon

[timwis]

I noticed an error about localhost:8080/favicon.ico not being found after an initial create-choo-app, which I found odd because create-choo-app creates an assets/icon.png file. I was able to get it working with:

npm start -- --html [ --favicon assets/icon.png ]

Though I imagine adding that arg to the start script is less than ideal. Is there another way this is supposed to work?

This is obviously low priority, just wanted to list it.

[yoshuawuyts]

Going to be fixed in bankai rewrite. See Also choojs/bankai#225

…

On Sun, Aug 13, 2017 at 4:58 PM Tim Wisniewski ***@***.***> wrote: I noticed an error about localhost:8080/favicon.ico not being found after an initial create-choo-app, which I found odd because create-choo-app creates an assets/icon.png file. I was able to get it working with: npm start -- --html [ --favicon assets/icon.png ] Though I imagine adding that arg to the start script is less than ideal. Is there another way this is supposed to work? This is obviously low priority, just wanted to list it. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#17>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACWlepqmCcPO85L-HNhjvuB2yFmql4G7ks5sXw8agaJpZM4O1taN> .