fix(modules): b12x 공유 wrapper 의 logger 정의 — 원본에 없는 이름을 썼다 - #81
Merged
Merged
Conversation
#80 이 logger.info_once 로 공유 발동을 남기는데, 이 파일의 원본에는 logger 가 아예 없다. py_compile 은 통과하고 부팅이 죽었다: RuntimeError: Worker failed with error 'name 'logger' is not defined' 로그 자체는 지우지 않는다 — 측정 스크립트가 그 줄로 공유가 실제로 걸렸는지 판정하고, 그게 없으면 직전 측정처럼 "아무것도 안 바뀐 상태"를 결론으로 삼게 된다. 컴파일이 아니라 컨테이너에서 실제 임포트로 확인했다: _shared_wrapper·logger· _B12X_WRAPPERS 전부 존재. py_compile 이 못 잡는 자리였다. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_a31cf0cf-40dd-4eed-99fe-823eca25418f) |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#80 이
logger.info_once로 공유 발동을 남기는데, 이 파일의 원본에는logger가 아예 없습니다.py_compile은 통과하고 부팅이 죽었습니다:로그는 지우지 않습니다
측정 스크립트가 그 줄로 공유가 실제로 걸렸는지 판정합니다. 직전 측정에서 PR 이 머지 안 된 채 돌았을 때 그 확인이 "판정 불가"를 띄워,
KV 16.52 → 9.79를 결론으로 삼는 것을 막았습니다.Verification
tests/test_logic.py— all OK🤖 Generated with Claude Code
Note
Low Risk
Adds only logger import and module-level initialization; no changes to MoE execution or memory-sharing logic.
Overview
Fixes a worker boot crash (
name 'logger' is not defined) in the B12x FlashInfer MoE overlay by wiring up the standard vLLM logger.Both
build/glm53/flashinfer_b12x_moe.pyandoverlay/modules/b12x_shared_workspace/flashinfer_b12x_moe.pynow importinit_loggerand setlogger = init_logger(__name__), so the existinglogger.info_once(...)in_shared_wrapper(shared wrapper creation) runs without error. No behavior change beyond making that observability log work; shared-wrapper logic is unchanged.Reviewed by Cursor Bugbot for commit 7856e5d. Bugbot is set up for automated code reviews on this repo. Configure here.