Use Awaited type to avoid Promise<Promise<T>>#68
Open
urbanfly wants to merge 2 commits intochodorowicz:mainfrom
Open
Use Awaited type to avoid Promise<Promise<T>>#68urbanfly wants to merge 2 commits intochodorowicz:mainfrom
urbanfly wants to merge 2 commits intochodorowicz:mainfrom
Conversation
urbanfly
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When debouncing a Promise-returning function, the returned function has a type of
Promise<Promise<T>>which is not accurate - see microsoft/TypeScript#27711In TypeScript 4.5, a new
Awaited<T>type was introduced to solve this problem.This PR simply wraps the
ReturnType<F>withAwaited<...>in order to get an accurate return type for the created function.Several packages were updated: