Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade choco-theme build dependencies #7

Closed
st3phhays opened this issue Jul 22, 2022 · 0 comments · Fixed by #8
Closed

Upgrade choco-theme build dependencies #7

st3phhays opened this issue Jul 22, 2022 · 0 comments · Fixed by #8
Assignees
@st3phhays
Labels
Enhancement Enhancements are things that are improvements or features.
Milestone
101.1.0

Comments

@st3phhays
Copy link
Member

st3phhays commented Jul 22, 2022 •
edited
Loading

Is Your Feature Request Related To A Problem? Please describe.

Some of the build dependencies that choco-theme relies on are out of date and need to be updated to their latest versions.

Describe The Solution. Why is it needed?

We do not want to introduce security vulnerabilities and want to take advantage of new bug fixes and features in newer versions of these packages.

Additional Context.

Most of these changes will be done in choco-theme itself, and pulled in via the yarn.lock file. Some changes to the gulpfile.js and other areas may be required to facilitate the updates.

Related Issues
@st3phhays st3phhays self-assigned this Jul 22, 2022
@st3phhays st3phhays added the Enhancement Enhancements are things that are improvements or features. label Jul 22, 2022
This was referenced Jul 22, 2022
Closed
Closed
Closed
Merged
Merged
Closed
@st3phhays st3phhays added this to the 101.1.0 milestone Jul 25, 2022
st3phhays added a commit to st3phhays/copenhagen_theme that referenced this issue Jul 25, 2022
@st3phhays
(chocolatey#7) Upgrade choco-theme and scripts
29d2afb 
All of the dependencies that are use by choco-theme have been upgraded
to the latest versions where possible. These mostly include development
build tools used by gulp and also yarn itself.

One big change was the switch from node-sass to dart-sass. This was
done because node-sass is now depreciated and was reporting security
vulnerabilities. With this change, slight modifications were needed in
some of the scss files in order to get the gulp builds working again.
This also requires each gulpfile.js to be updated in each repository to
use sass instead of node-sass.

With these updates, and the pinning of some packages in the resolutions
area in the package.json file, all security vulnerabilities are
resolved.
@st3phhays st3phhays mentioned this issue Jul 25, 2022
Merged
9 tasks
st3phhays added a commit that referenced this issue Jul 25, 2022
@st3phhays
Merge pull request #8 from st3phhays/dependabot
6bc814b 
(#7) Upgrade choco-theme and scripts
st3phhays added a commit to st3phhays/copenhagen_theme that referenced this issue Jul 25, 2022
@st3phhays
Merge pull request chocolatey#8 from st3phhays/dependabot
076babc 
(chocolatey#7) Upgrade choco-theme and scripts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@st3phhays st3phhays

Labels
Enhancement Enhancements are things that are improvements or features.
Projects
None yet
Milestone
101.1.0
Development

Successfully merging a pull request may close this issue.

(#7) Upgrade choco-theme and scripts st3phhays/copenhagen_theme
1 participant
@st3phhays