(#3255) Rewrite chocolateysetup.psm1

[vexx32]

Description Of Changes

• Rewrote the chocolateysetup.psm1 module we use to install Chocolatey

Motivation and Context

This script has barely been touched in the last decade, in part because it's difficult to follow. Gave it a much needed revision to remove unnecessary clutter, make its code patterns more consistent, and be much more sensible in how it declares and calls commands, so that we can be much more confident that things are working how we expect them to.

This should help make it much easier to make changes to going forward, should we ever need to.

Testing

Tests were performed on Win11, Server 2019, and Server 2008R2

1. Install from scratch using the install.ps1 script we provide on chocolatey.org, providing the -ChocolateyDownloadUrl to point at the locally-built nupkg.

• Note: on server 2008r2, I had to manually extract the nupkg and run the chocolateyInstall.ps1 due to Many Issues trying to make that script work on that ancient OS (mostly TLS issues I didn't wanna take the time to sort out).

3. Delete or move the C:\ProgramData\chocolatey folder, then install v2.0 or v2.1 of Chocolatey CLI, then do a choco upgrade --pre -s localfolder/ with the built nupkg in localfolder

Operating Systems Testing

• Win11
• Server 2019
• Server 2008R2

Change Types Made

• Bug fix (non-breaking change).
• Feature / Enhancement (non-breaking change).
• Breaking change (fix or feature that could cause existing functionality to change).
• Documentation changes.
• PowerShell code changes.

Change Checklist

• Requires a change to the documentation.
• Documentation has been updated.
• Tests to cover my changes, have been added.
• All new and existing tests passed?
• PowerShell code changes: PowerShell v2 compatibility checked?

Related Issue

Fixes #3255

[gep13]

@vexx32 would this be something that you could rebase onto the develop branch, so that we could see if we could get this pulled into the 2.5.0 release?

[vexx32]

Mmmm. Complicated. I'll have a stab at a rebase, it'll be manual though, too much has changed in this script since I think.

[vexx32]

@gep13 I've rebased this as best I can I think. I haven't had time to get it tested today to validate I've not re-broken anything, I'll have a look at that tomorrow.

EDIT: I think this is good now?