(#948) Add user as sensitive argument #3171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gep13
force-pushed
the
make-user-sensitive-argument
branch
from
9e3541a to
f04d63f
Compare
Since user is one half of the information that is needed for a credential, let's treat the user as sensitive information, in the same way that we treat password. This commit adds the various forms that the user option can be passed to the Chocolatey CLI, to ensure that it is always caught.
gep13
force-pushed
the
make-user-sensitive-argument
branch
from
f04d63f to
849d776
Compare
vexx32
approved these changes
May 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
This commit adds the various forms that the user option can be passed
to the Chocolatey CLI, to ensure that it is always caught.
Motivation and Context
Since user is one half of the information that is needed for a
credential, let's treat the user as sensitive information, in the same
way that we treat password.
Testing
Follow the steps in this PR: chocolatey/ChocolateyGUI#1002 and ensure that both user and password are not displayed.
This will require running the
Get-ChocoUpdatedDebugVersion.ps1script to pull through the latest version of Chocolatey CLI through to Chocolatey GUI.Operating Systems Testing
Windows 10
Change Types Made
Change Checklist
Related Issue
Relates to #948 where this functionality was first introduced.