(#508) Fix v3 feeds mixed with v2 feeds not finding packages #3159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates the FindPackage method we use when installing and acquiring information about a package to properly handle feeds when there is a mix of feeds that support v2 odata queries, and when there is one or more feeds that only support v3 feeds without the fallback to v2 odata APIs.
|
@AdmiringWorm thank you for getting this fixed up! I have taken this for a spin, and all seems good to me, and the automated testing is happy as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
This pull request updates the FindPackage method we use when installing
and acquiring information about a package to properly handle feeds
when there is a mix of feeds that support v2 odata queries, and when
there is one or more feeds that only support v3 feeds without the fallback
to v2 odata APIs.
Motivation and Context
Even when a user uses a mixture of v2 odata queries, v3 with odata v2 support and v3 only feeds, we should still be able to get the information about a specific package and be able to install/upgrade this package.
Testing
choco info isdependencywhile having both feeds configured, or passing in both sources using--sourcechoco install isdependencywhile having both feeds configured, or passing in both sources using--sourceOperating Systems Testing
Change Types Made
Change Checklist
Related Issue