(#508) Fix some files not being removed during uninstall/upgrade #3151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdmiringWorm
requested review from
gep13 and
vexx32
and removed request for
gep13
vexx32
requested changes
May 10, 2023
src/chocolatey/infrastructure.app/services/ChocolateyPackageInformationService.cs
Outdated
Show resolved
Hide resolved
src/chocolatey/infrastructure.app/services/ChocolateyPackageInformationService.cs
Outdated
Show resolved
Hide resolved
AdmiringWorm
force-pushed
the
PROJ-629/file-removal
branch
from
5fc7bcd to
fbdb577
Compare
|
@vexx32 thanks for catching those, I have updated the PR to fix the missing usage of throwError and using the correct parameter when formatting versions. |
corbob
requested changes
May 10, 2023
vexx32
reviewed
May 10, 2023
src/chocolatey/infrastructure.app/services/ChocolateyPackageInformationService.cs
Show resolved
Hide resolved
…tion This commit updates the file snapshot service to honor version normalization with fallbacks to old version methods. This is done as we are moving towards normalizing version numbers in most of the code, which causes a conflict when installing, upgrading or uninstalling packages that sometimes it would use non-normalized version number, and other times it would use normalized version numbers. Now with this change it will prefer to use normalized version number, but will continue to read/update package versions that was installed using non-normalized version numbers.
This commit updates the uninstall process to ensure that the nupkg file is removed, even in the cases where only partial file removals has happened. This will prevent the package from being listed as installed when partial removal is done. While the original code does not pose any problems with normal usage of CLI, it will not remove the nuget packages when the package has been modified, like what Licensed Extension does when optimizing installations.
There are several tests that are fixed by the changes in a previous commit, and in commits made in other projects. As such we need to remove the tag FossOnly from these tests.
corbob
force-pushed
the
PROJ-629/file-removal
branch
from
fbdb577 to
12bf790
Compare
Switch to use `--no-reduce` to prevent all reduction instead of just reducing the nupkg.
corbob
force-pushed
the
PROJ-629/file-removal
branch
from
12bf790 to
7cb721a
Compare
vexx32
approved these changes
May 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
This pull request makes changes to normalize the version number when creating file snapshots, and still support legacy version numbers. This fixes issues in licensed extension that would result in the file snapshot being null when trying to uninstall or upgrade packages.
Changes to ensure removal of nupkg files has also been added as if the nupkg file has been modified either manually, or by Chocolatey Licensed Extension it would be kept on disk during uninstalls and not removed.
Motivation and Context
To have uninstall and upgrade reliably works similar to how open source works.
Testing
Operating Systems Testing
Change Types Made
Change Checklist
Related Issue