(GH-2051) Fix: workingDirectory is always relpaced with the cache location #2006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous fix to address UNC paths broke the ability to provide a working directory to the Start-ChocolateyProcessAsAdmin helper function. The test "$workingDirectory.ProviderPath -eq $null" always evaluates to true because the String type does not have the member ProviderPath. The fix is to obtain the location object only when no path is provided to the helper and to verify its validity before use, possibly falling back to the cache location.
ferventcoder
changed the title
|
Rebased and merged into stable at 8d78c0a. Thanks so much for this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous fix to address UNC paths broke the ability to provide a
working directory to the Start-ChocolateyProcessAsAdmin helper function.
The test "$workingDirectory.ProviderPath -eq $null" always evaluates to
true because the String type does not have the member ProviderPath.
The fix is to obtain the location object only when no path is provided
to the helper and to verify its validity before use, possibly falling
back to the cache location.
Closes #2051