Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

choco search command does not use previously cached results #3125

Closed
2 tasks done
pauby opened this issue Apr 19, 2023 · 3 comments · Fixed by #3195
Closed
2 tasks done

choco search command does not use previously cached results #3125

pauby opened this issue Apr 19, 2023 · 3 comments · Fixed by #3195
Labels
5 - Released Improvement Requires NuGet.Client Change This issue requires a modification to something in referenced NuGet.Client library.
Milestone
2.1.0

Comments

@pauby
Copy link
Member

pauby commented Apr 19, 2023

Checklist

  • I have verified this is the correct repository for opening this issue.
  • I have verified no other issues exist related to my request.

Is Your Feature Request Related To A Problem? Please describe.

When doing a call to choco search it does not re-use a previously cached results, unlike what is done when calling choco install.

Describe The Solution. Why is it needed?

To keep it consistent with the results you would get with installations.

Additional Context

N/A

Related Issues
@pauby pauby added Improvement 0 - Backlog Requires NuGet.Client Change This issue requires a modification to something in referenced NuGet.Client library. labels Apr 19, 2023
@gep13 gep13 added this to the 2.1.0 milestone Jun 5, 2023
@gep13
Copy link
Member

gep13 commented Jun 5, 2023

While working on this issue, it was identified that this issue could also be addressed at the same time. This is due to the fact that by providing a ChocolateySourceCacheContext to all places that it is needed, to prevent a 1 second delay being applied to the outgoing query, the issue with the search queries not using the cached results, goes away.

Follow up issues will be created, and added to the 2.1.0 milestone to allow purging of the caches, as well as to allow skipping of the caches for certain queries.

This was referenced Jun 5, 2023
Closed
Closed
@gep13
Copy link
Member

gep13 commented Jun 5, 2023

Follow up issues have been created here and here, or allowing purging and skipping of cached queries.

gep13 added a commit to gep13/choco that referenced this issue Jun 5, 2023
@gep13
(chocolatey#3125) Use ChocolateySourceCacheContext for search
e5b3aa7 
In order to be consistent with how queries are cached when doing install
and upgrade commands, this commit switches to passing in an instance
of the ChocolateySourceCacheContext object, so that the choco search
comamnd makes use of the same cached query results.  This will mean
that all commands return consistent results.  It does mean that we will
need to provide an ability to by-pass/purge these caches, but that will
be part of another scope of work.
@gep13 gep13 mentioned this issue Jun 5, 2023
Merged
10 tasks
gep13 added a commit to gep13/choco that referenced this issue Jun 5, 2023
@gep13
(chocolatey#3125) Use ChocolateySourceCacheContext for search
c88d04a 
In order to be consistent with how queries are cached when doing install
and upgrade commands, this commit switches to passing in an instance
of the ChocolateySourceCacheContext object, so that the choco search
command makes use of the same cached query results.  This will mean
that all commands return consistent results.  It does mean that we will
need to provide an ability to by-pass/purge these caches, but that will
be part of another scope of work.
gep13 added a commit to gep13/choco that referenced this issue Jun 5, 2023
@gep13
(chocolatey#3125) Use ChocolateySourceCacheContext for search
df25555 
In order to be consistent with how queries are cached when doing install
and upgrade commands, this commit switches to passing in an instance
of the ChocolateySourceCacheContext object, so that the choco search
command makes use of the same cached query results.  This will mean
that all commands return consistent results.  It does mean that we will
need to provide an ability to by-pass/purge these caches, but that will
be part of another scope of work.
gep13 added a commit to gep13/choco that referenced this issue Jun 5, 2023
@gep13
(chocolatey#3125) Use ChocolateySourceCacheContext for search
824b041 
In order to be consistent with how queries are cached when doing install
and upgrade commands, this commit switches to passing in an instance
of the ChocolateySourceCacheContext object, so that the choco search
command makes use of the same cached query results.  This will mean
that all commands return consistent results.  It does mean that we will
need to provide an ability to by-pass/purge these caches, but that will
be part of another scope of work.
gep13 added a commit to gep13/choco that referenced this issue Jun 5, 2023
@gep13
(chocolatey#3125) Use ChocolateySourceCacheContext for search
aa888ad 
In order to be consistent with how queries are cached when doing install
and upgrade commands, this commit switches to passing in an instance
of the ChocolateySourceCacheContext object, so that the choco search
command makes use of the same cached query results.  This will mean
that all commands return consistent results.  It does mean that we will
need to provide an ability to by-pass/purge these caches, but that will
be part of another scope of work.
gep13 added a commit to gep13/choco that referenced this issue Jun 5, 2023
@gep13
(chocolatey#3125) Use ChocolateySourceCacheContext for search
88b1b96 
In order to be consistent with how queries are cached when doing install
and upgrade commands, this commit switches to passing in an instance
of the ChocolateySourceCacheContext object, so that the choco search
command makes use of the same cached query results.  This will mean
that all commands return consistent results.  It does mean that we will
need to provide an ability to by-pass/purge these caches, but that will
be part of another scope of work.
AdmiringWorm added a commit that referenced this issue Jun 5, 2023
@AdmiringWorm
Merge pull request #3195 from gep13/performance-fix
e3e2ba8 
(#3183 #3125) Fix performance issues with outbound HTTP queries
@gep13 gep13 added 4 - Done and removed 3 - Review labels Jun 5, 2023
@gep13 gep13 changed the title Search does not use previously cached results choco search command does not use previously cached results Jun 7, 2023
@choco-bot
Copy link

🎉 This issue has been resolved in version 2.1.0 🎉

The release is available on:

Your GitReleaseManager bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
5 - Released Improvement Requires NuGet.Client Change This issue requires a modification to something in referenced NuGet.Client library.
Projects
None yet
Milestone
2.1.0
Development

Successfully merging a pull request may close this issue.

(#3183 #3125) Fix performance issues with outbound HTTP queries gep13/choco
3 participants
@gep13 @choco-bot @pauby