Nuspec files with forward slash creates nested layer of directories when packed on Windows #2166
Labels
Milestone
Comments
|
This was fixed in the template by commit e5a02a0 But it can be fixed in all cases by chocolatey/nuget-chocolatey#19 |
TheCakeIsNaOH
added a commit
to TheCakeIsNaOH/choco
that referenced
this issue
May 7, 2021
When using a relative path, pack only works if the current directory is the same as the directory containing the nuspec. This switches the relative path to an absolute path for non-windows platforms (windows already uses an absolute path). This change allows pack to work from any directory. Previously, in c0b23a6 and e5a02a0, non-windows platforms were switched to using a relative path for files, so that the default files separator in the nuspec files element could be switched to a backslash (chocolatey#2166) However, the issue with forward/back slashes is fixed by nuget-chocolatey#19, so the previous changes can now be reverted.
TheCakeIsNaOH
added a commit
to TheCakeIsNaOH/choco
that referenced
this issue
May 7, 2021
When using a relative path, pack only works if the current directory is the same as the directory containing the nuspec. This switches the relative path to an absolute path for non-windows platforms (windows already uses an absolute path). This change allows pack to work from any directory. Previously, in c0b23a6 and e5a02a0, non-windows platforms were switched to using a relative path for files, so that the default files separator in the nuspec files element could be switched to a backslash (chocolatey#2166) However, the issue with forward/back slashes is fixed by chocolatey/nuget-chocolatey#19, so the previous change can now be reverted.
gep13
pushed a commit
to TheCakeIsNaOH/choco
that referenced
this issue
May 10, 2021
When using a relative path, pack only works if the current directory is the same as the directory containing the nuspec. This switches the relative path to an absolute path for non-windows platforms (windows already uses an absolute path). This change allows pack to work from any directory. Previously, in c0b23a6 and e5a02a0, non-windows platforms were switched to using a relative path for files, so that the default files separator in the nuspec files element could be switched to a backslash (chocolatey#2166) However, the issue with forward/back slashes is fixed by chocolatey/nuget-chocolatey#19, so the previous change can now be reverted.
TheCakeIsNaOH
added a commit
to TheCakeIsNaOH/NuGet.Client
that referenced
this issue
Jul 12, 2022
Converts the path separator character in the nuspec file source to the character that is correct for the OS that is running the packing operation. Changes "\" to "/" on Linux and MacOS systems, and changes "/" to "\" on Windows systems. Keeps chocolatey/choco#2166 fixed Based on this commit: chocolatey/nuget-chocolatey@979a47d
TheCakeIsNaOH
added a commit
to TheCakeIsNaOH/NuGet.Client
that referenced
this issue
Jul 12, 2022
Converts the path separator character in the nuspec file source to the character that is correct for the OS that is running the packing operation. Changes "\" to "/" on Linux and MacOS systems, and changes "/" to "\" on Windows systems. Keeps chocolatey/choco#2166 fixed Based on this commit: chocolatey/nuget-chocolatey@979a47d
TheCakeIsNaOH
added a commit
to TheCakeIsNaOH/NuGet.Client
that referenced
this issue
Jul 13, 2022
Converts the path separator character in the nuspec file source to the character that is correct for the OS that is running the packing operation. Changes "\" to "/" on Linux and MacOS systems, and changes "/" to "\" on Windows systems. Keeps chocolatey/choco#2166 fixed Based on this commit: chocolatey/nuget-chocolatey@979a47d
TheCakeIsNaOH
added a commit
to TheCakeIsNaOH/NuGet.Client
that referenced
this issue
Jul 27, 2022
Converts the path separator character in the nuspec file source to the character that is correct for the OS that is running the packing operation. Changes "\" to "/" on Linux and MacOS systems, and changes "/" to "\" on Windows systems. Keeps chocolatey/choco#2166 fixed Based on this commit: chocolatey/nuget-chocolatey@979a47d
TheCakeIsNaOH
added a commit
to TheCakeIsNaOH/NuGet.Client
that referenced
this issue
Jul 29, 2022
Converts the path separator character in the nuspec file source to the character that is correct for the OS that is running the packing operation. Changes "\" to "/" on Linux and MacOS systems, and changes "/" to "\" on Windows systems. Keeps chocolatey/choco#2166 fixed Based on this commit: chocolatey/nuget-chocolatey@979a47d
TheCakeIsNaOH
added a commit
to TheCakeIsNaOH/NuGet.Client
that referenced
this issue
Aug 1, 2022
Converts the path separator character in the nuspec file source to the character that is correct for the OS that is running the packing operation. Changes "\" to "/" on Linux and MacOS systems, and changes "/" to "\" on Windows systems. Keeps chocolatey/choco#2166 fixed Based on this commit: chocolatey/nuget-chocolatey@979a47d
TheCakeIsNaOH
added a commit
to TheCakeIsNaOH/NuGet.Client
that referenced
this issue
Nov 8, 2022
Converts the path separator character in the nuspec file source to the character that is correct for the OS that is running the packing operation. Changes "\" to "/" on Linux and MacOS systems, and changes "/" to "\" on Windows systems. Keeps chocolatey/choco#2166 fixed Based on this commit: chocolatey/nuget-chocolatey@979a47d
TheCakeIsNaOH
added a commit
to TheCakeIsNaOH/NuGet.Client
that referenced
this issue
Nov 8, 2022
Converts the path separator character in the nuspec file source to the character that is correct for the OS that is running the packing operation. Changes "\" to "/" on Linux and MacOS systems, and changes "/" to "\" on Windows systems. Keeps chocolatey/choco#2166 fixed Based on this commit: chocolatey/nuget-chocolatey@979a47d
TheCakeIsNaOH
added a commit
to TheCakeIsNaOH/NuGet.Client
that referenced
this issue
Nov 10, 2022
Converts the path separator character in the nuspec file source to the character that is correct for the OS that is running the packing operation. Changes "\" to "/" on Linux and MacOS systems, and changes "/" to "\" on Windows systems. Keeps chocolatey/choco#2166 fixed Based on this commit: chocolatey/nuget-chocolatey@979a47d
AdmiringWorm
pushed a commit
to chocolatey/NuGet.Client
that referenced
this issue
Nov 15, 2022
Converts the path separator character in the nuspec file source to the character that is correct for the OS that is running the packing operation. Changes "\" to "/" on Linux and MacOS systems, and changes "/" to "\" on Windows systems. Keeps chocolatey/choco#2166 fixed Based on this commit: chocolatey/nuget-chocolatey@979a47d
AdmiringWorm
pushed a commit
to chocolatey/NuGet.Client
that referenced
this issue
Nov 15, 2022
Converts the path separator character in the nuspec file source to the character that is correct for the OS that is running the packing operation. Changes "\" to "/" on Linux and MacOS systems, and changes "/" to "\" on Windows systems. Keeps chocolatey/choco#2166 fixed Based on this commit: chocolatey/nuget-chocolatey@979a47d
gep13
pushed a commit
to chocolatey/NuGet.Client
that referenced
this issue
Nov 16, 2022
Converts the path separator character in the nuspec file source to the character that is correct for the OS that is running the packing operation. Changes "\" to "/" on Linux and MacOS systems, and changes "/" to "\" on Windows systems. Keeps chocolatey/choco#2166 fixed Based on this commit: chocolatey/nuget-chocolatey@979a47d
gep13
pushed a commit
to chocolatey/NuGet.Client
that referenced
this issue
Nov 16, 2022
Converts the path separator character in the nuspec file source to the character that is correct for the OS that is running the packing operation. Changes "\" to "/" on Linux and MacOS systems, and changes "/" to "\" on Windows systems. Keeps chocolatey/choco#2166 fixed Based on this commit: chocolatey/nuget-chocolatey@979a47d
gep13
pushed a commit
to chocolatey/NuGet.Client
that referenced
this issue
Nov 17, 2022
Converts the path separator character in the nuspec file source to the character that is correct for the OS that is running the packing operation. Changes "\" to "/" on Linux and MacOS systems, and changes "/" to "\" on Windows systems. Keeps chocolatey/choco#2166 fixed Based on this commit: chocolatey/nuget-chocolatey@979a47d
gep13
pushed a commit
to chocolatey/NuGet.Client
that referenced
this issue
Nov 17, 2022
Converts the path separator character in the nuspec file source to the character that is correct for the OS that is running the packing operation. Changes "\" to "/" on Linux and MacOS systems, and changes "/" to "\" on Windows systems. Keeps chocolatey/choco#2166 fixed Based on this commit: chocolatey/nuget-chocolatey@979a47d
gep13
pushed a commit
to chocolatey/NuGet.Client
that referenced
this issue
Nov 17, 2022
Converts the path separator character in the nuspec file source to the character that is correct for the OS that is running the packing operation. Changes "\" to "/" on Linux and MacOS systems, and changes "/" to "\" on Windows systems. Keeps chocolatey/choco#2166 fixed Based on this commit: chocolatey/nuget-chocolatey@979a47d
gep13
pushed a commit
to chocolatey/NuGet.Client
that referenced
this issue
Nov 21, 2022
Converts the path separator character in the nuspec file source to the character that is correct for the OS that is running the packing operation. Changes "\" to "/" on Linux and MacOS systems, and changes "/" to "\" on Windows systems. Keeps chocolatey/choco#2166 fixed Based on this commit: chocolatey/nuget-chocolatey@979a47d
AdmiringWorm
pushed a commit
to chocolatey/NuGet.Client
that referenced
this issue
Nov 21, 2022
Converts the path separator character in the nuspec file source to the character that is correct for the OS that is running the packing operation. Changes "\" to "/" on Linux and MacOS systems, and changes "/" to "\" on Windows systems. Keeps chocolatey/choco#2166 fixed Based on this commit: chocolatey/nuget-chocolatey@979a47d
AdmiringWorm
pushed a commit
to chocolatey/NuGet.Client
that referenced
this issue
Nov 21, 2022
Converts the path separator character in the nuspec file source to the character that is correct for the OS that is running the packing operation. Changes "\" to "/" on Linux and MacOS systems, and changes "/" to "\" on Windows systems. Keeps chocolatey/choco#2166 fixed Based on this commit: chocolatey/nuget-chocolatey@979a47d
gep13
pushed a commit
to chocolatey/NuGet.Client
that referenced
this issue
Nov 21, 2022
Converts the path separator character in the nuspec file source to the character that is correct for the OS that is running the packing operation. Changes "\" to "/" on Linux and MacOS systems, and changes "/" to "\" on Windows systems. Keeps chocolatey/choco#2166 fixed Based on this commit: chocolatey/nuget-chocolatey@979a47d
gep13
pushed a commit
to chocolatey/NuGet.Client
that referenced
this issue
Nov 21, 2022
Converts the path separator character in the nuspec file source to the character that is correct for the OS that is running the packing operation. Changes "\" to "/" on Linux and MacOS systems, and changes "/" to "\" on Windows systems. Keeps chocolatey/choco#2166 fixed Based on this commit: chocolatey/nuget-chocolatey@979a47d
gep13
pushed a commit
to chocolatey/NuGet.Client
that referenced
this issue
Nov 21, 2022
Converts the path separator character in the nuspec file source to the character that is correct for the OS that is running the packing operation. Changes "\" to "/" on Linux and MacOS systems, and changes "/" to "\" on Windows systems. Keeps chocolatey/choco#2166 fixed Based on this commit: chocolatey/nuget-chocolatey@979a47d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What You Are Seeing?
When running
choco packon windows, if a file element in the.nuspechas a forward slash instead of a backslash, then nested directories will be created in the.nupkg.An example of this issue is visable with adobereader 2020.006.20034, where the
chocolateyinstall.ps1file is not intoolsbut intools\tools.The resulting package still does still "work", however, it is non-ideal behavior, and I can see edge cases where this could become problematic.
What is Expected?
That nested directories are not created.
How Did You Get This To Happen? (Steps to Reproduce)
.nuspecfiles element. Example: 4k-slideshow-maker<file src="tools\**" target="tools" />to<file src="tools/**" target="tools" />choco packon a Windows machine..nupkgThe text was updated successfully, but these errors were encountered: