(#857) Load Chocolatey executable assembly #858
Conversation
|
@AdmiringWorm this change will go out as a hotfix release, rather than as part of the next release from |
There was a problem hiding this comment.
This looks really good to me, just a couple of minor tweaks and suggestions. Can you update the commit message with information about why we need this change? i.e. to protect ourselves from incompatibilities when the version of Chocolatey installed globally is newer than what is shipped with Chocolatey GUI.
|
@AdmiringWorm am I right in saying that the changes that are included here result in the chocolatey.dll being omitted from the generated MSI, or is there additional work needed here? |
AdmiringWorm
force-pushed
the
use-choco-exec
branch
from
8cd59ad to
4c6a077
Compare
There is no additional work needed, due to all of the projects setting Requested changes have been made. |
This comment has been minimized.
This comment has been minimized.
This commit makes changes to the assembly loader to load the installed Chocolatey executable as an assembly instead of the statically referenced DLL file These changes are necessary to ensure that there will be minimal incompatibilities between running Chocolatey CLI and Chocolatey GUI for both FOSS and Licensed users.
AdmiringWorm
force-pushed
the
use-choco-exec
branch
from
4c6a077 to
232b47a
Compare
|
@AdmiringWorm thank you very much for working through this! |
This pull request updates the Chocolatey GUI and Chocolatey GUI CLI Assembly Loader to load the main Chocolatey executable as an assembly, instead of loading the included Chocolatey DLL file.
With the changes made here, the DLL file will no longer be included in the installation.
fixes #857