Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix logic of IsShowOnlyPackagesWithUpdateEnabled when PreventAutomatedOutdatedPackages is not set #822

Merged
merged 1 commit into from
Mar 9, 2021

Conversation

punker76
Copy link
Member

@punker76 punker76 commented Mar 8, 2021

The IsShowOnlyPackagesWithUpdateEnabled will be false if the PreventAutomatedOutdatedPackagesCheck is not set. So you will not see any updated packages without forcing the search for it.

This PR fix this issue.

Closes #821

…hen PreventAutomatedOutdatedPackages is not set

The IsShowOnlyPackagesWithUpdateEnabled will be false if the PreventAutomatedOutdatedPackagesCheck is not set. So you will not see any updated packages without forcing the search for it.
@punker76 punker76 requested a review from gep13 March 8, 2021 21:03
Copy link
Member

@gep13 gep13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gep13 gep13 merged commit 7c94a89 into chocolatey:develop Mar 9, 2021
@gep13
Copy link
Member

gep13 commented Mar 9, 2021

@punker76 thanks for finding and fixing this!

@punker76 punker76 deleted the fix/GH-821 branch March 9, 2021 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Option to only show packages with updates doesn't work correctly when automated outdated check is enabled
2 participants