Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(GH-741 GH-749) Add missing package parameters #750

Merged
merged 1 commit into from
Apr 5, 2020

Conversation

mkevenaar
Copy link
Contributor

I also switched to an helper.ps1 file for the package parameters to not
go over the 100 lines guideline.
Also the Package Parameter for UseDelayedSearch will now contain the
correct value.

Fixes #741 #749

I also switched to an helper.ps1 file for the package parameters to not
go over the 100 lines guideline.
Also the Package Parameter for UseDelayedSearch will now contain the
correct value.
Copy link
Member

@gep13 gep13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gep13 gep13 merged commit e7c67fe into chocolatey:develop Apr 5, 2020
@gep13
Copy link
Member

gep13 commented Apr 5, 2020

@mkevenaar your changes have been merged, thanks for your contribution 👍

@mkevenaar mkevenaar deleted the feature/GH-741 branch April 5, 2020 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ensure that all features/config can be set via parameters during installation of package
2 participants