Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Chinese language map #634

Merged
merged 1 commit into from
Jan 7, 2019
Merged

Added Chinese language map #634

merged 1 commit into from
Jan 7, 2019

Conversation

AdmiringWorm
Copy link
Member

A new language was added on transifex which uses the full language code, as such
this pr adds a transifex language mapping so the language code would be in the expected format for .NET.
Without this change, the language would be mapped as 'Resources.zh_CN.resx' and possibly make the program crash

@AdmiringWorm
(maint) Added Chinese language map
0b41e5d 
This commit adds a transifex language mapping
so the language code would be in the expected
format for .NET. Without this change, the
language would be mapped as 'Resources.zh_CN.resx'
and possibly make the program crash
mwallner
mwallner reviewed Jan 7, 2019
View reviewed changes
Copy link
Member

@mwallner mwallner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @AdmiringWorm , thanks for bringing this up.
just noticed: shouldn't there be more mappings i.e. for the German language (which is also translated via transifex) as well?

@gep13
Copy link
Member

gep13 commented Jan 7, 2019

@mwallner I believe I am right in saying that the other languages that we have don't use a full language code, for example German uses de:

image

The latest language that has been added uses a full language code zh_CN:

image

And I believe that this is why the mapping is required, since .Net uses zh-CN (NOTE: the usage of a - rather than a _)

@gep13 gep13 added the Documentation Issues for changes that only need to change documentation label Jan 7, 2019
@gep13 gep13 added this to the 0.17.0 milestone Jan 7, 2019
@gep13 gep13 merged commit 25af491 into chocolatey:develop Jan 7, 2019
@gep13
Copy link
Member

gep13 commented Jan 7, 2019

@AdmiringWorm your changes have been merged, thanks for your contribution 👍

@gep13
Copy link
Member

gep13 commented Jan 7, 2019

@AdmiringWorm I also added a note about this in the documentation:

274a277

@AdmiringWorm
Copy link
Member Author

@mwallner as @gep13 mentioned, this change isn't necessary to do when the culture is only two-part. And @gep13 is correct in his assessment of why the mapping is required.

@AdmiringWorm AdmiringWorm deleted the new-language-map branch January 7, 2019 17:17
@mwallner
Copy link
Member

mwallner commented Jan 7, 2019

cool, thanks for the clarification!

@gep13 gep13 changed the title (maint) Added Chinese language map Added Chinese language map Mar 26, 2020
@choco-bot
Copy link

🎉 This issue has been resolved in version 0.17.0 🎉

The release is available on:

Your GitReleaseManager bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mwallner mwallner mwallner left review comments

@gep13 gep13 gep13 approved these changes

Assignees
No one assigned
Labels
Documentation Issues for changes that only need to change documentation
Projects
None yet
Milestone
0.17.0
Development

Successfully merging this pull request may close these issues.
4 participants
@AdmiringWorm @gep13 @mwallner @choco-bot