Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remembered arguments are pulled from system Chocolatey install when debugging #980

Closed
4 tasks done
TheCakeIsNaOH opened this issue Jan 28, 2023 · 1 comment · Fixed by #981
Closed
4 tasks done

Remembered arguments are pulled from system Chocolatey install when debugging #980

TheCakeIsNaOH opened this issue Jan 28, 2023 · 1 comment · Fixed by #981
Assignees
@TheCakeIsNaOH
Labels
5 - Released The issue has been resolved, and released to the public for consumption NO RELEASE NOTES Should not be included in the release notes - not enhancing or fixing end product
Milestone
2.1.0

Comments

@TheCakeIsNaOH
Copy link
Member

TheCakeIsNaOH commented Jan 28, 2023 •
edited by gep13
Loading

Checklist

  • I have verified this is the correct repository for opening this issue.
  • I have verified no other issues exist related to my problem.
  • I have verified this is not an issue for a specific package.
  • I have verified this issue is not security related.

What You Are Seeing?

When trying to view remembered args for an installed package in debug Chocolatey GUI, it tries to load the remembered args from the system Chocolatey CLI install, instead of from the debug install.

What is Expected?

That it is able to load remembered args when debugging.

How Did You Get This To Happen?

  1. Build a debug version of Chocolatey GUI
  2. Install curl with package parameters
  3. View package parameters and see that it says there are either no remembered args or it displays the system wide args (depending if curl is installed in the system install of Chocolatey).

System Details

  • Operating System: Windows 10 22H2
  • Windows PowerShell version: 5.1
  • Chocolatey CLI Version: 1.2.1 (system), 2.0.0 debug (used)
  • Chocolatey Licensed Extension version: 5.1.0 (system), N/A
  • Chocolatey License type: Business
  • Terminal/Emulator: N/A

Installed Packages

curl

Output Log

N/A

Additional Context

N/A
@TheCakeIsNaOH TheCakeIsNaOH added the Bug Issues where something has happened which was not expected or intended label Jan 28, 2023
TheCakeIsNaOH added a commit to TheCakeIsNaOH/ChocolateyGUI that referenced this issue Jan 28, 2023
@TheCakeIsNaOH
(chocolatey#980) When using debug install, use assembly directory for…
16dfd2a 
… install location

This sets the Chocolatey install directory to the current assembly directory
when built as a debug build. This allows correctly getting the location of
remembered arguments from the debug installed package(s) instead of from
the systemwide install of Chocolatey.

If a debug build is in use, then ChocolateyGUI is using the chocolatey lib assembly,
so true can be returned in all cases.
@TheCakeIsNaOH TheCakeIsNaOH mentioned this issue Jan 28, 2023
Merged
10 tasks
@gep13 gep13 added the 3 - Review Code has been added, and is available for review as a pull request label Jun 9, 2023
@gep13 gep13 added this to the 2.1.0 milestone Jun 9, 2023
gep13 pushed a commit to TheCakeIsNaOH/ChocolateyGUI that referenced this issue Jun 9, 2023
@TheCakeIsNaOH @gep13
(chocolatey#980) Use assembly location when debugging
4e61429 
This sets the Chocolatey install directory to the current assembly
directory when built as a debug build. This allows correctly getting the
location of remembered arguments from the debug installed package(s)
instead of from the systemwide install of Chocolatey.

If a debug build is in use, then Chocolatey GUI is using the chocolatey
lib assembly, so true can be returned in all cases.
gep13 pushed a commit to TheCakeIsNaOH/ChocolateyGUI that referenced this issue Jun 9, 2023
@TheCakeIsNaOH @gep13
(chocolatey#980) Use assembly location when debugging
7a3a782 
This sets the Chocolatey install directory to the current assembly
directory when built as a debug build. This allows correctly getting the
location of remembered arguments from the debug installed package(s)
instead of from the systemwide install of Chocolatey.

If a debug build is in use, then Chocolatey GUI is using the chocolatey
lib assembly, so true can be returned in all cases.
@gep13 gep13 closed this as completed in #981 Jun 9, 2023
gep13 added a commit that referenced this issue Jun 9, 2023
@gep13
Merge pull request #981 from TheCakeIsNaOH/gh980-use-debug-install-lo…
e139d31 
…cation

(#980) When using debug install, use assembly directory for install location
@gep13 gep13 added 4 - Done Code has been added to the repository, and has been reviewed by a team member and removed 3 - Review Code has been added, and is available for review as a pull request labels Jun 9, 2023
@gep13 gep13 added the NO RELEASE NOTES Should not be included in the release notes - not enhancing or fixing end product label Jun 20, 2023
@gep13 gep13 removed the Bug Issues where something has happened which was not expected or intended label Jun 29, 2023
gep13 added a commit that referenced this issue Jun 29, 2023
@gep13
Merge branch 'release/2.1.0'
7cc2949 
* release/2.1.0:
  (maint) Update to latest version of chocolatey.lib
  (maint) Update GRM configuration file
  (maint) Remove version bump in nuspec file
  (build) Use latest Chocolatey.Cake.Recipe package
  (maint) Switch to Http for variable names
  (#1014) Add advanced option to ignore cached items
  (#1014) Ignore cached files on forced outdated check
  (build) Make build files consistent with others
  (#993) (fix) Correct syntax in KTS file
  (#993) Add TC schedule trigger
  (maint) Fix StyleCop warnings
  (#980) Use assembly location when debugging
  (maint) Update to released alpha package
  (#1003) Handle null keys during source translation
  (#1005) Normalize version numbers
  (maint) Add banned api analyzer
  (maint) Remove usage of obsolete methods
  (maint) Update to latest Chocolatey.Lib package
@gep13 gep13 added 5 - Released The issue has been resolved, and released to the public for consumption and removed 4 - Done Code has been added to the repository, and has been reviewed by a team member labels Jun 29, 2023
@choco-bot
Copy link

🎉 This issue has been resolved in version 2.1.0 🎉

The release is available on:

Your GitReleaseManager bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TheCakeIsNaOH TheCakeIsNaOH

Labels
5 - Released The issue has been resolved, and released to the public for consumption NO RELEASE NOTES Should not be included in the release notes - not enhancing or fixing end product
Projects
None yet
Milestone
2.1.0
3 participants
@gep13 @choco-bot @TheCakeIsNaOH