Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cuninst of Chocolatey GUI #97

Closed
gep13 opened this issue Feb 13, 2014 · 7 comments
Closed

Fix cuninst of Chocolatey GUI #97

gep13 opened this issue Feb 13, 2014 · 7 comments
Assignees
@RichiCoder1
Labels
Bug Issues where something has happened which was not expected or intended TaskItem Non-bug, non-feature related things. Could be refactoring. Sometimes non-code related things.
Milestone
0.12

Comments

@gep13
Copy link
Member

gep13 commented Feb 13, 2014

What ever I have done to get the new install working, I have broken the uninstall. Need to look into this.
@gep13 gep13 self-assigned this Feb 13, 2014
gep13 added a commit that referenced this issue Feb 18, 2014
@gep13
(#97) Fixing broken cuninst command
494fac1 
- With the changes to the WiX Package, the PackageName in the registry is no longer simply ChocolateyGUI, but rather it includes the version number
- The search that is done by the uninstall script has been adapted to account for this, by using a wildcard search
@gep13
Copy link
Member Author

gep13 commented Feb 18, 2014

@RichiCoder1 I am fairly sure that I have this working. Can you do an install and uninstall when you get a chance and make sure it is working? Cheers!

@gep13 gep13 assigned RichiCoder1 and unassigned gep13 Feb 18, 2014
@gep13 gep13 added this to the 0.12 milestone Feb 24, 2014
@RichiCoder1
Copy link
Contributor

What's the build URL I'm cinsting from again?

@gep13
Copy link
Member Author

gep13 commented Feb 24, 2014

It is in the Readme.md file here:

https://github.com/chocolatey/ChocolateyGUI

@RichiCoder1
Copy link
Contributor

Tested and it appears to work perfectly. Also made me find another bug which I fixed.

@gep13
Copy link
Member Author

gep13 commented Feb 24, 2014

@RichiCoder1 I think I just saw the same bug as you :-)

@RichiCoder1
Copy link
Contributor

Complained about not loading a dll right? Should be fixed in most recent push.

@gep13
Copy link
Member Author

gep13 commented Feb 24, 2014

Actually, no, this looks like it could be something else. I will post a new issue for tracking.

gep13 added a commit that referenced this issue Sep 16, 2014
@gep13
(#97) Fixing broken cuninst command
34307f4 
- With the changes to the WiX Package, the PackageName in the registry is no longer simply ChocolateyGUI, but rather it includes the version number
- The search that is done by the uninstall script has been adapted to account for this, by using a wildcard search
@gep13 gep13 added the Bug Issues where something has happened which was not expected or intended label Feb 25, 2015
@gep13 gep13 changed the title Fix cuninst of ChocolateyGUI Fix cuninst of Chocolatey GUI Sep 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RichiCoder1 RichiCoder1

Labels
Bug Issues where something has happened which was not expected or intended TaskItem Non-bug, non-feature related things. Could be refactoring. Sometimes non-code related things.
Projects
None yet
Milestone
0.12
Development

No branches or pull requests
2 participants
@gep13 @RichiCoder1