Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nuspec should use PNG Chocolatey Icon #880

Closed
gep13 opened this issue Sep 1, 2021 · 1 comment
Closed

Nuspec should use PNG Chocolatey Icon #880

gep13 opened this issue Sep 1, 2021 · 1 comment
Assignees
@gep13
Labels
Improvement Issues that enhances existing functionality, or adds new features
Milestone
0.18.2

Comments

@gep13
Copy link
Member

gep13 commented Sep 1, 2021

Instead of using the file at https://github.com/chocolatey/choco/raw/master/docs/logo/chocolateyicon.gif, we should use https://github.com/chocolatey/choco/raw/master/docs/logo/chocolateyicon.png - both files have been there for 5 years. This will help with systems that don't recognize GIF files.
@gep13 gep13 added the Improvement Issues that enhances existing functionality, or adds new features label Sep 1, 2021
@gep13 gep13 added this to the 0.18.2 milestone Sep 1, 2021
@gep13 gep13 self-assigned this Sep 1, 2021
gep13 added a commit that referenced this issue Sep 2, 2021
@gep13
(#880) Use PNG for Nuspec IconUrl
ea7b3c8 
Use PNG instead of GIF for the iconUrl in the nuspec. Use a location
that meets the published guidelines for iconUrl. This allows the icon
to be used with integrations that may not recognize GIF files.
@gep13 gep13 closed this as completed Sep 2, 2021
gep13 added a commit that referenced this issue Sep 2, 2021
@gep13
Merge branch 'hotfix/0.18.2'
3dff7ef 
* hotfix/0.18.2:
  (maint) Update to use correct URL
  (#880) Use PNG for Nuspec IconUrl
  (#857) Load Chocolatey executable assembly
gep13 added a commit that referenced this issue Sep 2, 2021
@gep13
Merge branch 'hotfix/0.18.2' into develop
0c626b4 
* hotfix/0.18.2:
  (maint) Update to use correct URL
  (#880) Use PNG for Nuspec IconUrl
  (#857) Load Chocolatey executable assembly
@choco-bot
Copy link

🎉 This issue has been resolved in version 0.18.2 🎉

The release is available on:

Your GitReleaseManager bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gep13 gep13

Labels
Improvement Issues that enhances existing functionality, or adds new features
Projects
None yet
Milestone
0.18.2
Development

No branches or pull requests
2 participants
@gep13 @choco-bot