Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contributing.md has broken links #854

Closed
KrisBierma opened this issue May 25, 2021 · 5 comments
Closed

Contributing.md has broken links #854

KrisBierma opened this issue May 25, 2021 · 5 comments
Assignees
Labels
5 - Released The issue has been resolved, and released to the public for consumption Documentation Issues for changes that only need to change documentation
Milestone

Comments

@KrisBierma
Copy link
Contributor

I’d like to contribute to Chocolatey but some of the links in the Contributing.md are dead, so I thought I’d update it first. There's a link to the CLA, but it’s blank. Is the ChocolateyGUI CLA the same one as the Chocolatey CLA? I know they’re different projects.
dead CLA link: https://www.clahub.com/agreements/chocolatey/ChocolateyGUI
chocolatey CLA link: https://cla-assistant.io/chocolatey/choco

Also, there’s a link for the mailing list, but it says ‘Content unavailable.’ https://groups.google.com/access-error?continue=https://groups.google.com/g/chocolateygui
When I do a search for ChocolateyGUI I see ‘No groups matched.’

Is it possible that the google groups mailing list isn't the best way to communicate? Perhaps it should be updated to gitter?

@gep13
Copy link
Member

gep13 commented May 25, 2021

@KrisBierma yes, Chocolatey GUI uses the same CLA as Chocolatey. You can see it in action on this PR:

#700

Regarding the Google Group, it does look like it is still working, but you will need to be signed in to see it:

https://groups.google.com/g/chocolateygui

It isn't a particularly well used avenue for asking/answering questions though, so I am ok with pointing people in a different direction. While Gitter is good for quick questions, searching isn't great. I think I would rather direct folks to ask questions via Discussions on the repository:

https://github.com/chocolatey/ChocolateyGUI/discussions

Thoughts?

@KrisBierma
Copy link
Contributor Author

@gep13 For the groups, I'm signed in with my personal email. I can search and see 'conversations matching query chocolateygui' but no 'groups.' If that's not really used, though, then I don't need to find it and this is just an fyi.

Since you're familiar with the project, I'll defer to you about the communication link. From your answer it sounds like the github discussions link is the best option.

@AdmiringWorm
Copy link
Member

Regarding the Google Group, it does look like it is still working, but you will need to be signed in to see it:

I wonder if there is some kind of permission issue (ie, the group is set as invite-only, private, etc).
Just tried the google group myself and seems I can not see it either (I never joined the group before).

I think it makes sense to change the link to direct to the discussion GitHub page instead though, due to the low traction in the google group.

@gep13
Copy link
Member

gep13 commented May 26, 2021

@AdmiringWorm it could well be that something changed with regard to the permissions of the Google Group, but I would prefer that we switch to Discussions, rather then invest any time in figuring out what is going on there.

@KrisBierma would you be interested in raising a PR to update both of these URL's?

KrisBierma added a commit to KrisBierma/ChocolateyGUI that referenced this issue May 27, 2021
@gep13 gep13 added the Documentation Issues for changes that only need to change documentation label May 30, 2021
@gep13 gep13 closed this as completed May 30, 2021
@gep13 gep13 added this to the 0.19.0 milestone May 30, 2021
@AdmiringWorm AdmiringWorm added the 4 - Done Code has been added to the repository, and has been reviewed by a team member label Jan 21, 2022
@gep13
Copy link
Member

gep13 commented Feb 10, 2022

🎉 This issue has been resolved in version 0.20.0 🎉

The release is available on:

Your GitReleaseManager bot 📦🚀

@corbob corbob added 5 - Released The issue has been resolved, and released to the public for consumption and removed 4 - Done Code has been added to the repository, and has been reviewed by a team member labels Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Released The issue has been resolved, and released to the public for consumption Documentation Issues for changes that only need to change documentation
Projects
None yet
Development

No branches or pull requests

4 participants