-
Notifications
You must be signed in to change notification settings - Fork 255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a feature to toggle on/off dark mode for application UI #685
Comments
@Vresod this is an interesting idea. This isn't something that I would be able to take on, as I am not a designer, so this would need some outside help in order for it to progress. |
@gep13 Even though you're not a designer, dark themes don't need to be difficult. If you want an idea go to DuckDuckGo search engine https://duckduckgo.com/ Settings - Themes and choose Dark or Terminal. The BG is simply a medium to dark gray and the text white to light gray. The Terminal version shows some colors for text (clicked and unclicked links, URLs, etc.). To see other colors used for certain searches: https://duckduckgo.com/?q=youtube-dl+how+to+download+audio+separate+youtube&t=ffab&ia=web&iax=qa I used a web page since it's not a program you need to install or download but the same principals apply. I did some screenshots just as an example. I basically just inverted the colors, which is really just the main principal of dark themes. White backgrounds to black or dark to medium gray and dark text would become white or light gray. While there could be colors (such as blue) there really doesn't have to be. It's a simple program so a simple grayscale theme would be fine. Don't forget the Settings pages and text boxes as well. =] I hope this helps. |
@gep13 @lucknaumann MahApps provides also a dark theme, so it should be easy to convert the existing "light" theme to a dark theme. |
@punker76 Sounds great! |
It sure do, and is pretty easy to change on the fly (would probably need to change how the styles are initially loaded though). var appStyle = ThemeManager.DetectAppStyle(Application.Current);
ThemeManager.ChangeAppStyle(Application.Current,
appStyle.Item2,
ThemeManager.GetAppTheme("BaseDark")); // Or BaseLight Reference: https://mahapps.com/guides/styles.html#thememanager |
@gep13 @AdmiringWorm Please excuse this question of ignorance but this is something can be implemented in Chocolatey GUI via Settings? If so, eagerly awaiting an update. Otherwise, I've no idea how to implement this. |
@punker76 has assigned himself this issue, so I think that this is something that he will be taking on. I don't know the details of the implementation, but I would suspect that modifying whether a dark/light theme is used is indeed something that would happen via the Settings screen. |
@gep13 Thanks for the info! |
Really hope this gets implemented. Every app should have a dark theme, it's just so much easier on the eyes. |
Hey, I just wanted to check-in and see how things were progressing. Any update on ETA for a dark theme? Thanks! |
bump. |
@JesFEREM unfortunately it is almost never as easy as that. Creating a dark theme (even just changing the background to black and the text to white) requires implementing a completely new style, updating the already used colors for different controls (background, foreground, border, etc) and make sure they don't clash with anything else. Implementing the ability to actually select the wanted style would also be needed. |
@punker76 is this triaged? |
@gregkolodny
it’s on my todo list and will come soon |
- MahApps.Metro.IconPacks to v3.5.0 - MahApps to latest alpha v2.0
Also make dark accent more lighten.
The background should not be hard coded to white.
- Update to latest MahApps.Metro and MahApps.Metro.IconPacks - Reduced size by using only necessary IconPacks
Implement BundledTheme which generates light and dark themes at runtime. The BundledTheme can also change the current theme via command. - Dark accent is too dark :-D - Extract code to ThemeAssist
- Improve TabItem selection foreground - Same DataGrid style in settings view - Remove unused Flyout resource - Use alternation row backgrounds
- Fix Styles for Markdig.Wpf
Also introduce resource keys for chocolatey colors and brushes.
Also fix ToggleSwtitch Caliburn event attachement.
With this it should be possible to implement a custom theme for ChocolateyGui.
…dark and light mode
This allows the ability to set a default selection for dark/light mode. This still allows for toggling the current selection, similar to what is done for the list/tile view.
Improve the standard remote view and detailed view. Also add the package icon to the detailed view.
Improve the standard remote view and detailed view. Also add the package icon to the detailed view. (chocolateyGH-685) Improve standard remote view
(GH-685) Update MahApps to latest source and introduce a dark mode
* release/0.18.0: (113 commits) (GH-821) Fix logic of IsShowOnlyPackagesWithUpdateEnabled when PreventAutomatedOutdatedPackages is not set (#820) Split default values for global and user (#741) Ensure all settings are included (maint) Remove unnecessary whitespace (#601) Change default for admin settings access (#820) Change default for tile view (#757) Allow buttons to be enabled/disabled (GH-685) Fix setting IsShowOnlyPackagesWithUpdateEnabled in local view (GH-685) Create converters only once (GH-685) Improve standard remote view (GH-685) Make converters more robust (GH-685) Add option to set default for dark mode (GH-685) Fix missing theme change in SyncTheme (GH-685) Update MahApps package (GH-685) Add ThemeMode and own ToggleSwitch with icons for dark and light mode (GH-685) Introduce IBundledThemeService (GH-685) Add better ScrollBar and ScrollViewer styles (GH-685) Improve progress dialog (GH-685) Add additional Chocolatey colors and brushes (GH-685) Remove obsolete unused styles ...
🎉 This issue has been resolved in version 0.18.0 🎉 The release is available on: Your GitReleaseManager bot 📦🚀 |
This could be put into the settings panel.
The text was updated successfully, but these errors were encountered: