-
Notifications
You must be signed in to change notification settings - Fork 255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ChocolateyLibDirHelper.VersionChangeFinished Index OOR Exception #36
Comments
Ok, maybe this happens independant of me setting that file. The application now starts with the Installed Packages tab selected and immediately gets that exception. |
Added some basic tests around building the list of installed packages and put some logic and a custom exception in for the version parsing from chocolately /? output, then switched to a regex match
Since the application couldn't find chocolatey, it was getting unexpected output from powershell. I changed the logic to explicitly throw a ChocolateyVersionUnknownException in this situation, but I'm not sure how we want to handle the logic higher up in the interface. Thoughts? |
Show a messagebox that say "Chocolatey can not be found do you wan tot install it?" On Yes install it with the little powershell script. On No just quit the application. But this should be rare since chocolateygui is supposed to be installed from chocolatey. |
Awesome, no idea how to do that. I'm unfamiliar with the way the application is interacting (using events for continuation) and I haven't done a windows app in years, so I may need someone to step in and do that last bit :) |
Switched frmo thread starts to TPL tasks with fault processing that passes the event back to the top. If it's a version exception we tell the user nicely and then exit
Code review? I added delegates for the Failed run, but switched from a Thread to using TPL (Task.Factory.StartNew) and lambdas to start and then handle faulted calls. I'm still trying to discover the root issue, which is why my chocolatey install isn't returning the expected version output :) |
can I close this? |
No, because I did, so there :) |
Loaded the application (in debug) with no saved settings. Went to menu and configured my settings folder. Clicked the "Installed Applications" tab and the load bar start going at bottom. Received an IndexOutOfRangeException:
The text was updated successfully, but these errors were encountered: