-
Notifications
You must be signed in to change notification settings - Fork 255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix rendering of headings in package description #356
Comments
Agreed. Now that we have a proper markdown engine, I'm thinking on how to restyle that whole central section. Any feedback in regards to that is welcome. |
@pascalberger based on the changes that @punker76 has recently made to the details page, can you comment on whether you would still like to see more changes in this area. If so, can you elaborate on exactly what you are looking for? |
IMHO still the same issue. For Visual Studio Code headings inside of the description appear in a bigger font size than the description header itself (size difference look even more in current release than in screenshot in #356 (comment)) |
@pascalberger the up to date screenshot is as follows: |
Yes, logically the topic tree looks like this:
But visually it looks for example like "Release Notes" is a sub point of "Package parameters" and it's visually not clear that "Features" and "Package parameters" belong to "Description", since "Description" is in a much lower font size. |
@pascalberger I am open to suggestions on how to improve this 😄 |
Can't we just apply a style to the rendering of the description field which results in H2 in the markdown content to be rendered in a style which is less prominent than "Description" is rendered? |
@pascalberger honestly, I am not sure. I wasn't really involved in the implementation of the markdown rendering in the current version of Chocolatey GUI, so I will need to do some digging into what can, and can't be done. |
The rendering of headings in description are larger then the headings of the Package view. To improve the Package view the headings outside of the description have now the same font size and weight. Also the Icon and the Id are moved to the left side. The right side is now vertically stretched and can be scrolled if it's to large.
@gep13 @pascalberger @ferventcoder @mwallner @AdmiringWorm @RichiCoder1 Here is my suggestion for the Package view: To improve the Package view the headings outside of the description have now the same font size and weight. Also the Icon and the Id are moved to the left side. The right side is now vertically stretched and can be scrolled if it's to large. |
this looks fantastic! |
Looks great |
🎉 This issue has been resolved in version 0.17.0 🎉 The release is available on: Your GitReleaseManager bot 📦🚀 |
See the Visual Studio Code Package, which follows the Core Team Packages Guidelines for Description.
While rendering of the description looks nice on chocolatey.org:
It looks quite strange in ChocolateyGUI with the headings inside of the description beeing more
accentuatet than the overall headings like "Description":
Versions
Chocolatey: v0.10.3 Professional
ChocolateyGUI: v0.14.0-unstable0145
The text was updated successfully, but these errors were encountered: