Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rendering of headings in package description #356

Closed
pascalberger opened this issue Dec 19, 2016 · 12 comments · Fixed by #664
Closed

Fix rendering of headings in package description #356

pascalberger opened this issue Dec 19, 2016 · 12 comments · Fixed by #664
Assignees
Labels
Improvement Issues that enhances existing functionality, or adds new features
Milestone

Comments

@pascalberger
Copy link
Contributor

pascalberger commented Dec 19, 2016

See the Visual Studio Code Package, which follows the Core Team Packages Guidelines for Description.

While rendering of the description looks nice on chocolatey.org:

unbenannt

It looks quite strange in ChocolateyGUI with the headings inside of the description beeing more
accentuatet than the overall headings like "Description":

unbenannt

Versions

Chocolatey: v0.10.3 Professional
ChocolateyGUI: v0.14.0-unstable0145

@RichiCoder1
Copy link
Contributor

Agreed. Now that we have a proper markdown engine, I'm thinking on how to restyle that whole central section. Any feedback in regards to that is welcome.

@RichiCoder1 RichiCoder1 added :UI Improvement Issues that enhances existing functionality, or adds new features labels Dec 19, 2016
@RichiCoder1 RichiCoder1 added this to the 0.15.0 milestone Dec 19, 2016
@RichiCoder1 RichiCoder1 removed the :UI label Feb 14, 2017
@RichiCoder1 RichiCoder1 modified the milestones: 0.15.0, Future Oct 4, 2017
@gep13
Copy link
Member

gep13 commented Apr 23, 2019

@pascalberger based on the changes that @punker76 has recently made to the details page, can you comment on whether you would still like to see more changes in this area.

If so, can you elaborate on exactly what you are looking for?

@pascalberger
Copy link
Contributor Author

IMHO still the same issue. For Visual Studio Code headings inside of the description appear in a bigger font size than the description header itself (size difference look even more in current release than in screenshot in #356 (comment))

@gep13
Copy link
Member

gep13 commented Apr 23, 2019

@pascalberger the up to date screenshot is as follows:

image

@pascalberger
Copy link
Contributor Author

Yes, logically the topic tree looks like this:

  • Package ID
  • Description
    • Features
    • Package parameters
  • Release Notes

But visually it looks for example like "Release Notes" is a sub point of "Package parameters" and it's visually not clear that "Features" and "Package parameters" belong to "Description", since "Description" is in a much lower font size.

@gep13
Copy link
Member

gep13 commented Apr 23, 2019

@pascalberger I am open to suggestions on how to improve this 😄

@pascalberger
Copy link
Contributor Author

Can't we just apply a style to the rendering of the description field which results in H2 in the markdown content to be rendered in a style which is less prominent than "Description" is rendered?
Maybe it would also help to make "Package ID", "Description" and "Release Notes" also a little bit more prominent to have more possibilities to style the headings of the description markdown test.

@gep13
Copy link
Member

gep13 commented Apr 23, 2019

@pascalberger honestly, I am not sure. I wasn't really involved in the implementation of the markdown rendering in the current version of Chocolatey GUI, so I will need to do some digging into what can, and can't be done.

@punker76 punker76 self-assigned this Apr 25, 2019
punker76 added a commit to punker76/ChocolateyGUI that referenced this issue Apr 25, 2019
The rendering of headings in description are larger then the headings of the Package view.
To improve the Package view the headings outside of the description have now the same font size and weight. Also the Icon and the Id are moved to the left side. The right side is now vertically stretched and can be scrolled if it's to large.
@punker76
Copy link
Member

@gep13 @pascalberger @ferventcoder @mwallner @AdmiringWorm @RichiCoder1

Here is my suggestion for the Package view:

To improve the Package view the headings outside of the description have now the same font size and weight. Also the Icon and the Id are moved to the left side. The right side is now vertically stretched and can be scrolled if it's to large.

2019-04-25_23h46_28

2019-04-25_23h46_51

chocopackage

@mwallner
Copy link
Member

this looks fantastic!

@pascalberger
Copy link
Contributor Author

Looks great :shipit:

punker76 added a commit to punker76/ChocolateyGUI that referenced this issue Apr 26, 2019
punker76 added a commit to punker76/ChocolateyGUI that referenced this issue Apr 26, 2019
gep13 added a commit that referenced this issue Apr 26, 2019
@gep13 gep13 modified the milestones: Future, 0.17.0 Apr 26, 2019
@gep13 gep13 changed the title Rendering of headings in description Fix rendering of headings in package description Mar 26, 2020
@choco-bot
Copy link

🎉 This issue has been resolved in version 0.17.0 🎉

The release is available on:

Your GitReleaseManager bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Issues that enhances existing functionality, or adds new features
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants