Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getting wix, app and choco version in line. #24

Closed
chrissie1 opened this issue Feb 11, 2013 · 6 comments
Closed

getting wix, app and choco version in line. #24

chrissie1 opened this issue Feb 11, 2013 · 6 comments
Labels
Improvement Issues that enhances existing functionality, or adds new features
Milestone

Comments

@chrissie1
Copy link
Contributor

They should probably all be the same on the 0.0.0 level.

@gep13
Copy link
Member

gep13 commented Feb 11, 2013

Not sure about you, but typically, we handle this with a CommonAssemblyInfo.cs file, and the version number in this file is updated each build, and is referenced everywhere that needs it. That way, you don't have to update the same information in multiple places.

@chrissie1
Copy link
Contributor Author

Never had to deal with this so no idea. How do you reference it.

@gep13
Copy link
Member

gep13 commented Feb 11, 2013

The CommonAssemblyInfo.cs is essentially a "partial" file. So you create a link to the common file, and remove the AssemblyInfo and AssemblyFileVersion from the AssemblyInfo.cs file. When it compiles, it takes the Version numbers from the Common file. You can do a similar thing with the wix project. Happy to make these changes, but I have asked Xavier a question related to this, so going to hold off until I hear from him about it.

@ghost ghost assigned gep13 Feb 12, 2013
gep13 added a commit that referenced this issue Feb 13, 2013
- This is the first attempt to use a common version number for all
projects, msi, and nuget packages.  Won't be able to test this properly
until all tests pass.
- Updated gitignore file to not check in BuildArtefacts
- Updated projects to use CommonAssemblyVersion and CommonWixInfo files
- Added psake build scripts
- Added build.bat file that will be used by MyGet Build Services
gep13 added a commit that referenced this issue Feb 14, 2013
In order to get the package building on MyGet, we have to stop the ICE
warnings.  This is detailed here:

http://stackoverflow.com/questions/1064580/wix-3-0-throws-error-217-while-being-executed-by-continuous-integration

Up shot,  we have to use the override, as we can't get admin permissions
on the build server.
@gep13
Copy link
Member

gep13 commented Feb 14, 2013

Okay, looks like this is pretty much complete. Now, we just need to decide on how we are controlling the version number. The build script, at the minute, hard codes the version into the default.ps1 file, however, there is a way to retrieve the build number from the git repo using tags and commit history (that is the code that is currently commented out in that file). This is quite a "clean" way of doing it, but it would need some setup and testing, so need some feedback as to whether we want to proceed down this route.

Can you let me know what you think?

gep13 added a commit that referenced this issue Feb 14, 2013
By adding a tag to the git repo, and then using the number of commits to
the repo since the tag, we can auto generate the version number.
@gep13
Copy link
Member

gep13 commented Feb 14, 2013

I have played with this, and I "think" that I have it working, just running a full build on MyGet just now.

Used this:

http://wptheming.com/2011/04/add-remove-github-tags/

as a reference.

@gep13
Copy link
Member

gep13 commented Feb 14, 2013

Woot, it works!

@gep13 gep13 closed this as completed Feb 14, 2013
@gep13 gep13 modified the milestones: 0.11.1, 0.11 Mar 5, 2015
@gep13 gep13 added the Improvement Issues that enhances existing functionality, or adds new features label Mar 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Issues that enhances existing functionality, or adds new features
Projects
None yet
Development

No branches or pull requests

2 participants