Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uninstall script doesn't wait for the uninstaller to finish #201

Closed
ComFreek opened this issue Dec 24, 2014 · 1 comment
Closed

Uninstall script doesn't wait for the uninstaller to finish #201

ComFreek opened this issue Dec 24, 2014 · 1 comment
Assignees
@gep13
Labels
Bug Issues where something has happened which was not expected or intended
Milestone
0.12

Comments

@ComFreek
Copy link

choco uninstall chocolateygui always finishes before the actual uninstaller is finished.

See also this comment in #199.
@ComFreek ComFreek mentioned this issue Dec 24, 2014
Closed
@gep13 gep13 added 2 - Working Bug Issues where something has happened which was not expected or intended labels Dec 24, 2014
@gep13 gep13 added this to the 0.12 milestone Dec 24, 2014
@gep13 gep13 self-assigned this Dec 24, 2014
gep13 added a commit that referenced this issue Dec 24, 2014
@gep13
(#201) Correcting uninstallation
c281bfb 
Rather than make a direct call to msiexec, use the Chocolatey Helper Method, which should handle waiting on the MSI to complete the uninstallation, and then carry on with writing Chocolatey success message.
gep13 added a commit that referenced this issue Dec 24, 2014
@gep13
(#201) Working around bug in Chocolatey
0ba3c0d 
Looks like there is an issue here:

https://github.com/chocolatey/chocolatey/blob/master/src/helpers/functions/Uninstall-ChocolateyPackage.ps1#L51

The $file parameter is never passed into the call to msiexec, so it never knows which msi to call.
@gep13
Copy link
Member

gep13 commented Dec 24, 2014

@ComFreek this has been corrected, and deployed to MyGet. Thanks for reporting it!

@gep13 gep13 closed this as completed Dec 24, 2014
RichiCoder1 pushed a commit to RichiCoder1/ChocolateyGUI that referenced this issue Jun 29, 2015
@gep13 @RichiCoder1
(chocolatey#201) Correcting uninstallation
9b78420 
Rather than make a direct call to msiexec, use the Chocolatey Helper Method, which should handle waiting on the MSI to complete the uninstallation, and then carry on with writing Chocolatey success message.
RichiCoder1 pushed a commit to RichiCoder1/ChocolateyGUI that referenced this issue Jun 29, 2015
@gep13 @RichiCoder1
(chocolatey#201) Working around bug in Chocolatey
2650c06 
Looks like there is an issue here:

https://github.com/chocolatey/chocolatey/blob/master/src/helpers/functions/Uninstall-ChocolateyPackage.ps1#L51

The $file parameter is never passed into the call to msiexec, so it never knows which msi to call.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gep13 gep13

Labels
Bug Issues where something has happened which was not expected or intended
Projects
None yet
Milestone
0.12
Development

No branches or pull requests
2 participants
@gep13 @ComFreek