Skip to content

(GH-33) Resolve HyperV deprecation warning for differencing vs linked clone #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 31, 2019
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion Vagrantfile
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,11 @@ Vagrant.configure("2") do |config|
# The time in seconds to wait for the virtual machine to report an IP address
v.ip_address_timeout = 130
# Use differencing disk instead of cloning whole VHD
v.differencing_disk = true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When did we add the bit about differencing? Linked Clone is all I've used... hmm

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nevermind, this is HyperV - good to see they are making the naming consistent (as they should be).

if Vagrant::VERSION >= '2.1.2'
v.linked_clone = true
else
v.differencing_disk = true
end
v.vm_integration_services = {
guest_service_interface: true,
heartbeat: true,
Expand Down