Skip to content

(inkscape) drop 32 bit support #2572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

TheCakeIsNaOH
Copy link
Member

Description

As the 32bit version of inkscape has been dropped, remove support from package.

Motivation and Context

Fixes #2552

How Has this Been Tested?

Tested on Win10 22H2 and in test env

Screenshot (if appropriate, usually isn't needed):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Migrated package (a package has been migrated from another repository)

Checklist:

  • My code follows the code style of this repository.
  • My change requires a change to documentation (this usually means the notes in the description of a package).
  • I have updated the documentation accordingly (this usually means the notes in the description of a package).
  • I have updated the package description and it is less than 4000 characters.
  • All files are up to date with the latest Contributing Guidelines
  • The added/modified package passed install/uninstall in the Chocolatey Test Environment(https://github.com/chocolatey-community/chocolatey-test-environment/). Note that we don't support the use of any other environment.
  • The changes only affect a single package (not including meta package).

@AppVeyorBot
Copy link

✅ Package verification completed without issues. PR is now pending human review

@AdmiringWorm AdmiringWorm self-requested a review November 26, 2024 11:19
Copy link
Member

@AdmiringWorm AdmiringWorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The removal looks good in general, however we also need to add a note in the Readme.md file that mentions the removal of 32bit support.

See the nodejs package as a quick example:

- Starting with version 23.x, installations for 32bit platforms are no longer supported. If this is required, an older version is required to be used.

As the 32bit version of inkscape has been dropped, remove support from package.
@AppVeyorBot
Copy link

✅ Package verification completed without issues. PR is now pending human review

@mgmax
Copy link
Contributor

mgmax commented Feb 2, 2025

@AdmiringWorm friendly reminder :-) - If there are any improvements needed, please let us know

@corbob corbob dismissed AdmiringWorm’s stale review February 8, 2025 03:50

The requested change has been made.

@corbob corbob merged commit bbca4ba into chocolatey-community:master Feb 8, 2025
1 check passed
@corbob
Copy link
Contributor

corbob commented Feb 8, 2025

Thanks for getting this fixed up @TheCakeIsNaOH 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(inkscape) Outdated - New release 1.4
6 participants