Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(#27)(#39)(#46)(#45) Rework and update the repository #47

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

TheCakeIsNaOH
Copy link
Member

@TheCakeIsNaOH TheCakeIsNaOH commented Jan 11, 2024

This is a major rework and update of the files in the repository. This removes ketarin references, switches au to chocolatey-au, and updates the scripts based on updates to the the majkinetor and chocolatey-community/chocolatey-packages repositories.

Fixes #27
Fixes #39
Fixes #45
Fixes #46

…eferences

Also removes template/example packages from ketarin
@TheCakeIsNaOH TheCakeIsNaOH force-pushed the fixups branch 2 times, most recently from c4b07e5 to 2108e1f Compare January 11, 2024 17:22
@TheCakeIsNaOH TheCakeIsNaOH marked this pull request as ready for review January 11, 2024 17:26
@TheCakeIsNaOH TheCakeIsNaOH changed the title (#46)(#45) Rework and update the repository (#27)(#39)(#46)(#45) Rework and update the repository Jan 11, 2024
Copy link
Member

@pauby pauby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are minor corrections.

This all looks good to me. I can't comments on the appveyor scripts / yml file without running it. But at a glance it looks fine.

Thats for doing all this work @TheCakeIsNaOH

setup/README.md Outdated Show resolved Hide resolved
setup/README.md Outdated Show resolved Hide resolved
Copy link
Member

@AdmiringWorm AdmiringWorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes LGTM, and it looks like most of the changes are similar to what is being used in https://github.com/chocolatey-community/chocolatey-packages. Before I put a final approval from me, though, I would like to test out the image used in the AppVeyor script in the above mentioned repository.

I'll schedule some time next week to make those changes in that repository and come back to this PR afterward.

tnc1997 added a commit to tnc1997/chocolatey-packages that referenced this pull request May 5, 2024
.appveyor.yml Outdated Show resolved Hide resolved
.appveyor.yml Outdated Show resolved Hide resolved
.appveyor.yml Outdated Show resolved Hide resolved
update_all.ps1 Outdated Show resolved Hide resolved
Copy link

@JPRuskin JPRuskin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good to me (two minor comments) - but I think it's still waiting on testing of the AppVeyor changes.

setup/au_setup.ps1 Outdated Show resolved Hide resolved
test_all.ps1 Outdated Show resolved Hide resolved
@Jaykul
Copy link

Jaykul commented Sep 22, 2024

@JPRuskin @TheCakeIsNaOH what are we waiting for?
I just about went and started on this work myself, before I saw the PR ;-)

@TheCakeIsNaOH
Copy link
Member Author

@Jaykul I'm waiting for review on this PR, it should be someone else that approves and merges this (or asks for changes).

@pauby
Copy link
Member

pauby commented Sep 30, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants