Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Out of sync with au-packages-template #39

Open
unsolaci opened this issue Jul 15, 2021 · 6 comments · May be fixed by #47
Open

Out of sync with au-packages-template #39

unsolaci opened this issue Jul 15, 2021 · 6 comments · May be fixed by #47

Comments

@unsolaci
Copy link

AU scripts seem to be out of date / out of sync with majkinetor/au-packages-template.

I can see some sync commits (57aa601, 5811f8c, 6738ecb) by @majkinetor over the years, but it seems that there hasn't been one for a while now, even though the AU scripts in majkinetor/au-packages-template are considerably newer.

@majkinetor
Copy link
Contributor

Yes, that is the case. I initially handled both, but that is not OK use of my time so I continued only on au-packages-template. Having one template instead of 2 makes much more sense anyway and is less confusing.

I would deprecate this on but its not up to me.

@pauby
Copy link
Member

pauby commented Jul 16, 2021

I agree that we should deprecate it and update the documentation.

@unsolaci
Copy link
Author

I agree that we should deprecate it and update the documentation.

@pauby what about manual packages though? majkinetor/au-packages-template is only for automatic packages, right?

I know that a directory for manual packages can simply be added to majkinetor/au-packages-template on one's own. But still it would be nice to have a single template for all kinds of packages, that the docs could point to. It's just an opinion though 💡.

@pauby
Copy link
Member

pauby commented Jul 16, 2021

majkinetor/au-packages-template is only for automatic packages, right?

It is. We're discussing that template here.

My thoughts were to remove the template entirely and point to the official AU docs.

@majkinetor
Copy link
Contributor

majkinetor commented Jul 16, 2021

No its not, you can have manual packages. I do have more manual myself then automatic. Its just not separated in different folders. Automatic packages have update.ps1, manual generally don't.

@unsolaci
Copy link
Author

No its not, you can have manual packages. I do have more manual myself then automatic. Its just not separated in different folders. Automatic packages have update.ps1, manual generally don't.

Oh! Okay, so in this case it does indeed seem to make more sense to deprecate and update the docs on that matter.

TheCakeIsNaOH added a commit to TheCakeIsNaOH/chocolatey-packages-template that referenced this issue Jan 11, 2024
TheCakeIsNaOH added a commit to TheCakeIsNaOH/chocolatey-packages-template that referenced this issue Jan 12, 2024
TheCakeIsNaOH added a commit to TheCakeIsNaOH/chocolatey-packages-template that referenced this issue Jul 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants