Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(#58) Implement requirement rule CPMR0074 #59

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

AdmiringWorm
Copy link
Member

Description Of Changes

This introduces the latest requirement rule that was added in Package
Validator related to verifying that hook packages has not been used as a dependency.

Motivation and Context

We want to have the rules implemented in Package Validator implemented in the community extension.

Testing

  1. Create a new package nuspec using choco new.
  2. Update the dependencies list to include a dependency on a package ending with .hook.
  3. Run choco pack against the nuspec.
  4. Verify the rule CPMR0074 is flagged.

Operating Systems Testing

  • Windows 10

Change Types Made

  • Bug fix (non-breaking change).
  • Feature / Enhancement (non-breaking change).
  • Breaking change (fix or feature that could cause existing functionality to change).
  • Documentation changes.
  • PowerShell code changes.

Change Checklist

  • Requires a change to the documentation.
  • Documentation has been updated.
  • Tests to cover my changes, have been added.
  • All new and existing tests passed?
  • PowerShell code changes: PowerShell v3 compatibility checked?

Related Issue

Fixes #58

@AdmiringWorm AdmiringWorm requested a review from gep13 December 5, 2024 14:11
@AdmiringWorm AdmiringWorm self-assigned this Dec 5, 2024
Copy link
Member

@gep13 gep13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

This introduces the latest requirement rule that was added in Package
Validator related to verifying that hook packages has not been used as a dependency.
@gep13 gep13 enabled auto-merge December 5, 2024 16:06
@gep13 gep13 merged commit 51cd93e into chocolatey-community:develop Dec 5, 2024
1 check passed
@AdmiringWorm AdmiringWorm deleted the issue58 branch December 5, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement requirement rule CPMR0074 - Dependency On Hook Package
2 participants