(#28) Add rule to disallow icon URL using GitHub links #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gep13
requested changes
Dec 5, 2024
src/Chocolatey.Community.Validation.Tests/Rules/IconUrlElementRulesTest.cs
Outdated
Show resolved
Hide resolved
…links This introduces a new requirement rule that flags any icon URL that makes use of GitHub, either usercontent, gists or the main domain as well as the rawgit domain that is no longer possible to use properly.
|
@AdmiringWorm thanks for getting this fixed up! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
This introduces a new requirement rule that flags any icon URL that
makes use of GitHub, either usercontent, gists or the main domain as
well as the rawgit domain that is no longer possible to use properly.
Motivation and Context
We want a rule that flags and prevents using GitHub raw urls.
Testing
choco new.https://github.com/chocolatey-community/chocolatey-packages/blob/master/icons/7zip.svgchoco packagainst the created nuspec.CPMR0076is flagged and shown in the console.https://github.com/chocolatey-community/chocolatey-packages/raw/refs/heads/master/icons/filezilla.svghttps://raw.githubusercontent.com/chocolatey-community/chocolatey-packages/refs/heads/master/icons/1password4.pnghttps://cdn.rawgit.com/chocolatey/chocolatey-coreteampackages/049a3a3d/icons/winff.pngOperating Systems Testing
Change Types Made
Change Checklist
Related Issue
Fixes #28