Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(#19) Add action to build project #21

Merged
merged 2 commits into from
Jan 16, 2024
Merged

(#19) Add action to build project #21

merged 2 commits into from
Jan 16, 2024

Conversation

AdmiringWorm
Copy link
Member

Description Of Changes

This adds a new GitHub workflow file to be able to build the project
when a PR or a community member pushes up changes.

This is to give a quicker indication on failures than having to look at
our private builds (or a community member needing to reach out to a
Chocolatey Team Member to check).

The artifacts from the build (the extension/packages) themself are not
included with this build as they won't be able to be ran on any systems.
Only the unit tests can be ran as part of this workflow.

Motivation and Context

To give quicker information to those submitting pull requests, and to community members that do not have access to private builds.

Testing

  1. The action has been ran on my own fork here: https://github.com/chocolatey/.github/actions/runs/7542269832/job/20530697481

Operating Systems Testing

  • Microsoft Windows Server 2019 (10.0.17763)

Change Types Made

  • Bug fix (non-breaking change).
  • Feature / Enhancement (non-breaking change).
  • Breaking change (fix or feature that could cause existing functionality to change).
  • Documentation changes.
  • PowerShell code changes.
  • Build Related

Change Checklist

  • Requires a change to the documentation.
  • Documentation has been updated.
  • Tests to cover my changes, have been added.
  • All new and existing tests passed?
  • PowerShell code changes: PowerShell v2 compatibility checked?

Related Issue

Fixes #19

This adds a new GitHub workflow file to be able to build the project
when a PR or a community member pushes up changes.

This is to give a quicker indication on failures than having to look at
our private builds (or a community member needing to reach out to a
Chocolatey Team Member to check).

The artifacts from the build (the extension/packages) themself are not
included with this build as they won't be able to be ran on any systems.
Only the unit tests can be ran as part of this workflow.
@AdmiringWorm AdmiringWorm self-assigned this Jan 16, 2024
@AdmiringWorm AdmiringWorm requested a review from gep13 January 16, 2024 13:41
Copy link
Member

@gep13 gep13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gep13 gep13 merged commit 8c75a98 into chocolatey-community:develop Jan 16, 2024
@gep13
Copy link
Member

gep13 commented Jan 16, 2024

@AdmiringWorm thanks for getting this added!

@gep13 gep13 deleted the gh-build-file branch January 16, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a GitHub action to build the project
2 participants