Skip to content

When a release is being created the license URL generated is incorrect #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
5 tasks done
AdmiringWorm opened this issue Jan 18, 2024 · 1 comment · Fixed by #27
Closed
5 tasks done

When a release is being created the license URL generated is incorrect #26

AdmiringWorm opened this issue Jan 18, 2024 · 1 comment · Fixed by #27
Assignees
@AdmiringWorm
Labels
5 - Released The issue has been resolved, and released to the public for consumption Build Automation Issues for changes to the build system, without functional changes needed to the project
Milestone
0.2.0

Comments

@AdmiringWorm
Copy link
Member

Checklist

  • I have verified this is the correct repository for opening this issue.
  • I have verified no other issues exist related to my problem.
  • I have verified this is not an issue for a specific package.
  • I have verified this issue is not security related.
  • I confirm I am using official, and not unofficial, or modified, Chocolatey products.

What You Are Seeing?

In our build processes we are generating a license URL on the fly, when it tries to generate one for a tag the URL becomes an invalid URL.

What is Expected?

The license URL should be valid when we create tag releases.

How Did You Get This To Happen?

  1. Start the release process
  2. Take the artifact generated from an internal build
  3. extract the content and look at the VERIFICATION.txt and the license url in the nuspec file.
  4. Notice these are missing the mention of the tag name.

System Details

N/A

Installed Packages

N/A

Output Log

N/A

Additional Context

No response
@AdmiringWorm AdmiringWorm added Build Automation Issues for changes to the build system, without functional changes needed to the project 0 - _Triaging Issue is accepted, but a milestone has yet to be added for the issue labels Jan 18, 2024
@AdmiringWorm AdmiringWorm self-assigned this Jan 18, 2024
@AdmiringWorm AdmiringWorm added 2 - Working A user or team member has started working on the issue and removed 0 - _Triaging Issue is accepted, but a milestone has yet to be added for the issue labels Jan 18, 2024
AdmiringWorm added a commit to AdmiringWorm/chocolatey-community-validation that referenced this issue Jan 18, 2024
@AdmiringWorm
(chocolatey-community#26) Use milestone for license URL replacement
7819246 
This updates the relpacement used when creating a license URL
to make use of the Build Version Milestone, instead of the tag name.

This is done as in certain scenarios the tag name is an empty string and will
cause an invalid URL to be generated. This causes problems when doing a
release of the product, and thus changing to the milestone is more
appropriate.
@AdmiringWorm AdmiringWorm mentioned this issue Jan 18, 2024
Merged
10 tasks
@AdmiringWorm AdmiringWorm added 3 - Review Code has been added, and is available for review as a pull request and removed 2 - Working A user or team member has started working on the issue labels Jan 18, 2024
@gep13 gep13 closed this as completed in #27 Jan 18, 2024
gep13 added a commit that referenced this issue Jan 18, 2024
@gep13
Merge pull request #27 from AdmiringWorm/fix-license-replacement
698a713 
(#26) Use milestone for license URL replacement
@gep13 gep13 added 4 - Done Code has been added to the repository, and has been reviewed by a team member and removed 3 - Review Code has been added, and is available for review as a pull request labels Jan 18, 2024
AdmiringWorm pushed a commit to AdmiringWorm/chocolatey-community-validation that referenced this issue Jan 18, 2024
@gep13 @AdmiringWorm
Merge pull request chocolatey-community#27 from AdmiringWorm/fix-lice…
8786128 
…nse-replacement

(chocolatey-community#26) Use milestone for license URL replacement

(cherry picked from commit 698a713)
@AdmiringWorm AdmiringWorm added this to the 0.2.0 milestone Jan 19, 2024
@AdmiringWorm AdmiringWorm added 5 - Released The issue has been resolved, and released to the public for consumption and removed 4 - Done Code has been added to the repository, and has been reviewed by a team member labels Feb 1, 2024
@AdmiringWorm AdmiringWorm added 4 - Done Code has been added to the repository, and has been reviewed by a team member and removed 5 - Released The issue has been resolved, and released to the public for consumption labels Dec 11, 2024
AdmiringWorm added a commit to AdmiringWorm/chocolatey-community-validation that referenced this issue Dec 11, 2024
@AdmiringWorm
Merge branch 'release/0.2.0'
e88ef08 
* release/0.2.0: (21 commits)
  (maint) Fix incorrect label used in config
  (chocolatey-community#58) Implement requirement rule CPMR0074
  (chocolatey-community#28) Add rule to disallow icon URL using GitHub links
  (chocolatey-community#37) Implement note rule CPMR0068
  (chocolatey-community#36) Implement note rule CPMR0067
  (maint) Set explicit PlatformTarget for console
  (maint) synced local '.github/ISSUE_TEMPLATE/' with remote '.github/ISSUE_TEMPLATE/'
  (chocolatey-community#38) Add rule for validating ID length
  (chocolatey-community#39) Add rule for validating underscore in ID
  (chocolatey-community#34) Implement note rule CPMR0061 - Id Contains "."
  (maint) synced local '.github/PULL_REQUEST_TEMPLATE.md' with remote '.github/PULL_REQUEST_TEMPLATE.md'
  (build) Update Chocolatey.Cake.Recipe to latest
  (chocolatey-community#35) Implement note rule CPMR0062
  (build) Update to latest Recipe package
  (maint) synced local '.github/ISSUE_TEMPLATE/' with remote '.github/ISSUE_TEMPLATE/'
  (chocolatey-community#32) Update Help URLs to short link
  (chocolatey-community#29) Add missing release notes to generated packages
  (maint) Update extension name in Readme
  (maint) synced local '.templates/' with remote '.github/GitReleaseManager/.templates/'
  (chocolatey-community#26) Use milestone for license URL replacement
  ...
@AdmiringWorm AdmiringWorm added 5 - Released The issue has been resolved, and released to the public for consumption and removed 4 - Done Code has been added to the repository, and has been reviewed by a team member labels Dec 11, 2024
@AdmiringWorm
Copy link
Member Author

🎉 This issue has been resolved in version 0.2.0 🎉

The release is available on:

Your GitReleaseManager bot 📦 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AdmiringWorm AdmiringWorm

Labels
5 - Released The issue has been resolved, and released to the public for consumption Build Automation Issues for changes to the build system, without functional changes needed to the project
Projects
None yet
Milestone
0.2.0
Development

Successfully merging a pull request may close this issue.

(#26) Use milestone for license URL replacement AdmiringWorm/chocolatey-community-validation
2 participants
@gep13 @AdmiringWorm