Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(#45) Update build process with release findings #48

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

corbob
Copy link
Contributor

@corbob corbob commented Mar 12, 2024

Description Of Changes

Update the build process based on the findings of the 1.0.0 release.

  • Do not publish artifacts on a PR build.
  • Do not fail build on missing publish tokens, instead print a warning and gracefully exit.
  • Add icon to the Chocolatey Package.
  • Update Chocolatey Package encoding to correct display issue on Chocolatey Community Repository.

Motivation and Context

Minor things discovered during the release of 1.0.0.

Testing

  • Run git tag 1.0.1 to generate a git tag locally.
  • Run ./build.ps1 -Task CI
  • Ensure that warning emitted on the publish step that the package was not published due to not having publishing keys.
  • Push the build package to the test Community Repository.
  • Ensure icon and software author's display correctly on test Community Repository.
  • Ensure that Team City build does not publish to internal repositories.

Operating Systems Testing

N/A

Change Types Made

  • Bug fix (non-breaking change).
  • Feature / Enhancement (non-breaking change).
  • Breaking change (fix or feature that could cause existing functionality to change).
  • Documentation changes.
  • PowerShell code changes.
  • Build Process updates

Change Checklist

  • Requires a change to the documentation.
  • Documentation has been updated.
  • Tests to cover my changes, have been added.
  • All new and existing tests passed?
  • PowerShell code changes: PowerShell v2 compatibility checked?

Related Issue

Fixes #45

Update the build process based on the findings of the 1.0.0 release.

- Do not publish artifacts on a PR build.
- Do not fail build on missing publish tokens, instead print a warning
  and gracefully exit.
- Add icon to the Chocolatey Package.
- Update Chocolatey Package encoding to correct display issue on
  Chocolatey Community Repository.
@@ -10,6 +10,7 @@
<summary>Chocolatey-AU is Powershell module that helps you to automate Chocolatey package updates</summary>
<description></description>
<projectUrl>https://github.com/chocolatey-community/chocolatey-au</projectUrl>
<iconUrl>https://chocolatey.org/assets/images/nupkg/chocolateyicon.png</iconUrl>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is under the chocolatey-community user, it probably should not be using the icon for official products? Similar to chocolatey-community/chocolatey-templates#11 a new icon would probably need to be created.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 for some reason I thought I had taken this icon from the Chocolatey Community Validation Extension, but it looks like it's not using an icon either. Perhaps this one should leave the extension off for now.

@corbob corbob marked this pull request as draft March 12, 2024 23:44
@corbob
Copy link
Contributor Author

corbob commented Mar 12, 2024

Setting this back to Draft because apparently the publish step isn't picking up that it's a Pull Request, which means that it is not ready for merging until I can spend some time tracking that down 🤷‍♂️. It also means that all pushes to it will fail to build on Team City until I get that sorted out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build Process Adjustments Based on 1.0.0 Release
2 participants