Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build Process Adjustments Based on 1.0.0 Release #45

Open
4 tasks done
corbob opened this issue Mar 11, 2024 · 0 comments · May be fixed by #48
Open
4 tasks done

Build Process Adjustments Based on 1.0.0 Release #45

corbob opened this issue Mar 11, 2024 · 0 comments · May be fixed by #48
Assignees
@corbob
Labels
2 - Working A user or team member has started working on the issue Build Automation Issues for changes to the build system, without functional changes needed to the project

Comments

@corbob
Copy link
Contributor

corbob commented Mar 11, 2024 •
edited
Loading

Some things discovered while releasing version 1.0.0:

  • While adding (maint) Minor Build Process Updates #44, it was found that it was trying to push the PowerShell Module to an internal repository. This should not happen on PR builds.
  • GitHub Action attempts to push to PowerShell Gallery on tagged release. It shouldn't do this.
  • There is no icon for the Chocolatey Package.
  • Miodrag's name under Software Authors is mangled on the Chocolatey Community Repository.
@corbob corbob mentioned this issue Mar 12, 2024
Closed
62 tasks
@corbob corbob changed the title Build Process - PR builds should not push packages to repositories. Build Process Adjustments Based on 1.0.0 Release Mar 12, 2024
corbob added a commit to corbob/chocolatey-au that referenced this issue Mar 12, 2024
@corbob
(chocolatey-community#45) Update build process with release findings
20252b4 
Update the build process based on the findings of the 1.0.0 release.

- Do not publish artifacts on a PR build.
- Do not fail build on missing publish tokens, instead print a warning
  and gracefully exit.
- Add icon to the Chocolatey Package.
- Update Chocolatey Package encoding to correct display issue on
  Chocolatey Community Repository.
@corbob corbob linked a pull request Mar 12, 2024 that will close this issue
Draft
11 tasks
@corbob corbob self-assigned this Mar 12, 2024
@corbob corbob added 3 - Review Code has been added, and is available for review as a pull request Build Automation Issues for changes to the build system, without functional changes needed to the project 2 - Working A user or team member has started working on the issue and removed 3 - Review Code has been added, and is available for review as a pull request labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@corbob corbob

Labels
2 - Working A user or team member has started working on the issue Build Automation Issues for changes to the build system, without functional changes needed to the project
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

(#45) Update build process with release findings corbob/chocolatey-au
1 participant
@corbob