Skip to content

Adding critical test flag #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
raimundovidaljunior merged 2 commits into from
May 13, 2025
Merged

Adding critical test flag #54

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
164f7bb
Adding critical test flag
raimundovidaljunior Apr 28, 2025
4adb4e6
ADding missing params
raimundovidaljunior Apr 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion dagger/dag_creator/airflow/operator_creators/soda_creator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ def __init__(self, task, dag):
self._table_name = task.table_name
self._output_s3_path = task.output_s3_path
self._output_table = task.output_table
self._is_critical_test = task.is_critical_test
self._vars = task.vars

def _generate_command(self):
Expand All @@ -23,7 +24,8 @@ def _generate_command(self):

command.append(f"--output_s3_path={self._output_s3_path}")
command.append(f"--output_table={self._output_table}")

if self._is_critical_test:
command.append(f"--is_critical_test={self._is_critical_test}")
if self._table_name:
command.append(f"--table_name={self._table_name}")
if self._vars:
Expand Down
12 changes: 12 additions & 0 deletions dagger/pipeline/tasks/soda_task.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,14 @@ def init_attributes(cls, orig_cls):
required=False,
comment="Athena table that will contain the scan results.",
),
Attribute(
attribute_name="is_critical_test",
parent_fields=["task_parameters"],
validator=str,
required=False,
comment="True if test run is critical test. Defaults to False",

),
Attribute(
attribute_name="vars",
parent_fields=["task_parameters"],
Expand All @@ -64,6 +72,7 @@ def __init__(self, name, pipeline_name, pipeline, job_config):
self._output_table = self.parse_attribute("output_table") or conf.SODA_DEFAULT_OUTPUT_TABLE
self._output_s3_path = self.parse_attribute("output_s3_path") or conf.SODA_DEFAULT_OUTPUT_S3_PATH
self._table_name = self.parse_attribute("table_name")
self._is_critical_test = self.parse_attribute("is_critical_test")
self._vars = self.parse_attribute("vars")


Expand All @@ -80,6 +89,9 @@ def output_s3_path(self):
@property
def table_name(self):
return self._table_name
@property
def is_critical_test(self):
return self._is_critical_test

@property
def vars(self):
Expand Down