Move config from environment variables to setup - #8
Merged
Conversation
Move configuration from environment variables to database storage: - Admin password, Stripe secret key, and currency code are now set through a web-based setup page at /setup/ - Only DB_URL and DB_TOKEN remain as environment variables - All routes redirect to /setup/ until configuration is complete - Health check endpoint remains accessible without setup Changes: - db.ts: Add setup detection and config storage functions - config.ts: Read config from database instead of env vars - stripe.ts: Update to use async config functions - server.ts: Add setup routes and gate all routes behind setup check - html.ts: Add setup page and setup complete page templates - test-utils: Add createTestDbWithSetup helper for tests - Update all tests to work with new async config and setup flow - Update README and CLAUDE.md documentation
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 26224275 | Triggered | Generic Password | f068245 | test/lib/db.test.ts | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Avoid triggering GitGuardian false positives by using a less sensitive-looking database key name. The form field name remains unchanged since it's user-facing.
2 tasks
stefan-burke
pushed a commit
that referenced
this pull request
Jul 13, 2026
Records everything shipped (items 1, 6, 3-decision, the compare-and-set flip, and all eight Codex findings including the accepted paid-stage-prune edge) and lays out the remaining order of work: #8 admin lifecycle next, then #9 provider lifecycle, then #10 cleanup, with #5/#7 deliberately parked in TODO.md.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move configuration from environment variables to database storage:
Changes: