Skip to content

Remove one dead export and one comment about replaced code - #2120

Merged
stefan-burke merged 2 commits into
mainfrom
claude/payment-sandbox-e2e-tests-ffo03m
Aug 20, 2026
Merged

stefan-burke merged 2 commits into
mainfrom
claude/payment-sandbox-e2e-tests-ffo03m

Conversation

@stefan-burke

Copy link
Copy Markdown
Member

What this changes

A self-review of PR #2116 against AGENTS.md, run after that pull request was reviewed, found three breaches of the repository's own rules. This pull request fixes the two small ones and records the third. Everything is in e2e-payments/. No behaviour changes.

The two fixes

A dead export. PR #2116 gave the harness one artifactsRoot, and every module outside server.ts now reaches the artifacts directory through it. That left repoRoot exported with no importer anywhere in the repository. AGENTS.md says an unused export is dead code and must be deleted, so repoRoot becomes a module-local constant. It is still used four times inside server.ts.

A comment about replaced code. The teardown guard in browser.ts said the leak is "raised instead of logged", which describes what the code replaced rather than what it does. AGENTS.md: "Do not leave comments that compare current code with an old implementation." Git history keeps the old version. The comment now states the current constraint only, and is a line shorter.

The third finding, recorded not fixed

Three harness files are above the ~400-line guideline, and two crossed it in #2116: cucumber/steps/booking.ts at 484, browser.ts at 430, and flow.ts at 404. The splits are clean and already visible in the code — the click-witness helpers leave browser.ts whole, and the webhook-evidence block is one concept in booking.ts. They are churn without a live run to prove them, so TODO.md now carries the entry with the file list and the seams, for the next change that opens the harness.

How it was checked

  • deno check on both changed modules, deno task lint:ci, deno task cpd, and deno task check:comments all pass.
  • No test or run was needed: one export loses a keyword and one comment loses a clause, so no code path changes.

🤖 Generated with Claude Code

https://claude.ai/code/session_016P57K88JA6T9Z1UPiFjqtc


Generated by Claude Code

claude added 2 commits August 20, 2026 09:26
Self-review against AGENTS.md found two small breaches of its rules.

Every module outside server.ts now reaches the artifacts directory
through artifactsRoot, so the repoRoot export has no caller left. An
export nothing imports is dead surface, so repoRoot becomes local.

The teardown comment said the leak is "raised instead of logged",
which describes what the code replaced rather than what it does. Git
history keeps the old version. The comment now states the current
constraint only, in three lines rather than four.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_016P57K88JA6T9Z1UPiFjqtc
Self-review of PR #2116 against AGENTS.md found three e2e-payments
files above the 400-line guideline, two of which crossed it in that
pull request. The splits are real but they are churn without a run to
prove them, so they wait for the next change that opens the harness.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_016P57K88JA6T9Z1UPiFjqtc
@coderabbitai

coderabbitai Bot commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your current included review allowance is based on your included PR review attempts over the past 7 days.

Next review available in: 43 minutes

Limit details: You’ve used the included review currently available. Your 99 included PR review attempts over the past 7 days set your current allowance at 1 review per hour.

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

Wait for the limit to reset, then comment @coderabbitai review or push new commits to the PR.

An organization admin can change what happens after included review limits in Billing.

How do review limits work?

CodeRabbit enforces per-developer PR review limits within each organization.

For paid Pro and Pro+ reviews, CodeRabbit uses a developer's included PR review attempts over the past 7 days to set the current hourly allowance. At typical activity levels, the full plan allowance applies. Higher sustained activity can lower the allowance until earlier attempts leave the 7-day window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 1f5f99fe-c375-4a4a-9bcb-85f9cf55c52a

📥 Commits

Reviewing files that changed from the base of the PR and between f9b67e2 and fb8668b.

📒 Files selected for processing (3)
  • TODO.md
  • e2e-payments/src/browser.ts
  • e2e-payments/src/server.ts

Comment @coderabbitai help to get the list of available commands.

@stefan-burke
stefan-burke added this pull request to the merge queue Aug 20, 2026
Merged via the queue into main with commit d008682 Aug 20, 2026
3 checks passed
@stefan-burke
stefan-burke deleted the claude/payment-sandbox-e2e-tests-ffo03m branch August 20, 2026 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants