Remove one dead export and one comment about replaced code - #2120
Conversation
Self-review against AGENTS.md found two small breaches of its rules. Every module outside server.ts now reaches the artifacts directory through artifactsRoot, so the repoRoot export has no caller left. An export nothing imports is dead surface, so repoRoot becomes local. The teardown comment said the leak is "raised instead of logged", which describes what the code replaced rather than what it does. Git history keeps the old version. The comment now states the current constraint only, in three lines rather than four. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016P57K88JA6T9Z1UPiFjqtc
Self-review of PR #2116 against AGENTS.md found three e2e-payments files above the 400-line guideline, two of which crossed it in that pull request. The splits are real but they are churn without a run to prove them, so they wait for the next change that opens the harness. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016P57K88JA6T9Z1UPiFjqtc
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 43 minutes Limit details: You’ve used the included review currently available. Your 99 included PR review attempts over the past 7 days set your current allowance at 1 review per hour. Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?Wait for the limit to reset, then comment An organization admin can change what happens after included review limits in Billing. How do review limits work?CodeRabbit enforces per-developer PR review limits within each organization. For paid Pro and Pro+ reviews, CodeRabbit uses a developer's included PR review attempts over the past 7 days to set the current hourly allowance. At typical activity levels, the full plan allowance applies. Higher sustained activity can lower the allowance until earlier attempts leave the 7-day window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
Comment |
What this changes
A self-review of PR #2116 against
AGENTS.md, run after that pull request was reviewed, found three breaches of the repository's own rules. This pull request fixes the two small ones and records the third. Everything is ine2e-payments/. No behaviour changes.The two fixes
A dead export. PR #2116 gave the harness one
artifactsRoot, and every module outsideserver.tsnow reaches the artifacts directory through it. That leftrepoRootexported with no importer anywhere in the repository.AGENTS.mdsays an unused export is dead code and must be deleted, sorepoRootbecomes a module-local constant. It is still used four times insideserver.ts.A comment about replaced code. The teardown guard in
browser.tssaid the leak is "raised instead of logged", which describes what the code replaced rather than what it does.AGENTS.md: "Do not leave comments that compare current code with an old implementation." Git history keeps the old version. The comment now states the current constraint only, and is a line shorter.The third finding, recorded not fixed
Three harness files are above the ~400-line guideline, and two crossed it in #2116:
cucumber/steps/booking.tsat 484,browser.tsat 430, andflow.tsat 404. The splits are clean and already visible in the code — the click-witness helpers leavebrowser.tswhole, and the webhook-evidence block is one concept inbooking.ts. They are churn without a live run to prove them, soTODO.mdnow carries the entry with the file list and the seams, for the next change that opens the harness.How it was checked
deno checkon both changed modules,deno task lint:ci,deno task cpd, anddeno task check:commentsall pass.🤖 Generated with Claude Code
https://claude.ai/code/session_016P57K88JA6T9Z1UPiFjqtc
Generated by Claude Code