Repository navigation
Make the tests catch every change in thirteen files, and delete two checks that ran twice #2110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 10 commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
56da980
Stop the runaway pending-work test from outliving its own assertion
claude 652d230
Bound the superuser password draw so starved randomness fails loudly
claude 4be75e5
Close the crypto and redirect survivors
claude 6914c9d
Pin what the attendees browser offers and what it ignores
claude 2de7390
Pin the flush round cap and the single-listing price sync
claude 8532039
Pin the route tie-break against declaration order
claude 8cf4045
Close the superuser survivors, and fix an off-by-one in the draw cap
claude 7ee684c
Move the missing-member test to the file it belongs to
claude e5c1011
Name every word a page may not take
claude fbf7de5
Cover the listing-attendee reads nobody was checking
claude c15cafb
Refuse a malformed round count instead of throwing, and tighten two t…
claude 570e08c
Settle the flush boundary test on ports instead of timers
claude 16568a5
Invalidate on what a write assigns, not on which word it starts with
claude 3c2761c
Check an imported listing's parent links in one place, not two
claude adc2419
Say the new words in the edge guard's own test too
claude 52b6d50
Pin what happens when Logistics is turned off under pressure
claude f66171b
Read the import refusals from the message catalog in the wider tests too
claude 94c354f
Write down the parent-link survivors this branch surfaced but does no…
claude 45f4ee6
Keep one copy of the two import refusals, not two
claude 22e8c2e
Merge remote-tracking branch 'origin/main' into followup/sweep-survivors
claude 53dd996
Write the new comments and notes in Simplified Technical English
claude ec38167
Test the counting edges of the pricing engine
claude 0309729
Record the early drop of an untriggered modifier as unkillable
claude 9864661
Name the three shapes the parent-link survivors take
claude ce66899
Merge branch 'main' into followup/sweep-survivors
stefan-burke 1f801e4
Merge remote-tracking branch 'origin/main' into followup/sweep-survivors
claude 56848c0
Ask again when a released port is taken before the test can use it
claude 9e592cf
Merge remote-tracking branch 'origin/main' into followup/sweep-survivors
claude 31c25a3
Merge remote-tracking branch 'origin/main' into followup/sweep-survivors
claude File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
25 changes: 25 additions & 0 deletions
25
test/features/admin/catalog-transfer/import-listing/member-ids.test.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| /** | ||
| * Spotting a member that vanished between resolving names and the | ||
| * transaction's own read. | ||
| */ | ||
|
|
||
| import { expect } from "@std/expect"; | ||
| import { it as test } from "@std/testing/bdd"; | ||
| import { missingMemberId } from "#routes/admin/catalog-transfer/import-listing.ts"; | ||
|
|
||
| const found = new Map([ | ||
| [1, {}], | ||
| [3, {}], | ||
| ]); | ||
|
|
||
| test("reports nothing when every member was found", () => { | ||
| expect(missingMemberId([1, 3], found)).toBeNull(); | ||
| expect(missingMemberId([], found)).toBeNull(); | ||
| }); | ||
|
|
||
| test("reports the first member that is missing, not one that is present", () => { | ||
| expect(missingMemberId([1, 2, 3], found)).toBe(2); | ||
| // Two gaps: the earlier one is the one reported. | ||
| expect(missingMemberId([2, 4], found)).toBe(2); | ||
| expect(missingMemberId([4, 2], found)).toBe(4); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.